Include the examples cross imports checker in the analzyer. by justinmc · Pull Request #190674 · flutter/flutter

justinmc · 2026-08-06T18:19:52Z

When we landed the script, we forgot to include it as part of the analzyer check.

We forgot to do this when it was first landed.

gemini-code-assist

Code Review

This pull request adds a new validation step named 'cross-imports-examples' to the validation list in dev/bots/analyze.dart to run the check_examples_cross_imports.dart script. I have no feedback to provide.

…ated

navaronbracke

So this was why we were thinking it wasn't running?

justinmc · 2026-08-06T19:47:54Z

Yes it must have been, because look at all of the failures in CI now: https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8674194619156241281/+/u/run_test.dart_for_analyze_shard_and_subshard_None/stdout

A bunch in the api/ directory that I wasn't expecting, too.

justinmc · 2026-08-06T23:04:11Z

-    'examples/multiple_windows/lib/app/main_window.dart',
-    'examples/multiple_windows/lib/app/tooltip_button.dart',
-    'examples/multiple_windows/lib/app/tooltip_window_edit_dialog.dart',
-    'examples/multiple_windows/lib/app/dialog_window_content.dart',
-    'examples/multiple_windows/lib/app/dialog_window_edit_dialog.dart',
-    'examples/multiple_windows/lib/app/popup_window_content.dart',
-    'examples/multiple_windows/lib/app/window_content.dart',
-    'examples/multiple_windows/lib/app/window_edit_dialog.dart',
-    'examples/multiple_windows/lib/app/rotated_wire_cube.dart',
-    'examples/multiple_windows/lib/app/popup_window_edit_dialog.dart',
-    'examples/multiple_windows/lib/app/tooltip_window_content.dart',
-    'examples/multiple_windows/lib/app/popup_button.dart',
-    'examples/multiple_windows/lib/app/window_settings_dialog.dart',
-    'examples/multiple_windows/lib/main.dart',
-    'examples/multiple_windows/test/multiple_windows_test.dart',


These we forgot to remove when we migrated the multiple_windows test.

navaronbracke · 2026-08-07T06:10:22Z

    'examples/api/test/ui/text/font_feature.font_feature_subscripts.0_test.dart',
    'examples/api/test/ui/text/font_feature.font_feature_character_variant.0_test.dart',
    'examples/api/lib/widgets/animated_grid/sliver_animated_grid.0.dart',
+    'examples/api/lib/widgets/expansible/expansible.0.dart',


Where do these additions come from?

When I enabled the script, the analyzer failed because these files have cross imports in them. Did we somehow miss these in your initial PR because it wasn't running in CI?

They used to be tests in material, and were moved to widgets by #189532

Ah that's it, thanks.

justinmc · 2026-08-06T23:04:48Z

@@ -384,6 +392,13 @@ class ExamplesCrossImportChecker {
    'examples/api/lib/widgets/scrollbar/raw_scrollbar.desktop.0.dart',
    'examples/api/lib/widgets/inherited_notifier/inherited_notifier.0.dart',
    'examples/api/lib/widgets/text_magnifier/text_magnifier.0.dart',
+    'examples/api/test/widgets/selection_container/selection_container_disabled.0_test.dart',
+    'examples/api/test/widgets/selection_container/selection_container.0_test.dart',
+    'examples/api/test/widgets/platform_menu_bar/platform_menu_bar.0_test.dart',
+    'examples/api/test/widgets/context_menu/context_menu_controller.0_test.dart',
+    'examples/api/test/widgets/context_menu/editable_text_toolbar_builder.0_test.dart',
+    'examples/api/test/widgets/context_menu/editable_text_toolbar_builder.1_test.dart',
+    'examples/api/test/widgets/selectable_region/selectable_region.0_test.dart',


These I guess we missed when landing the cross import example checker.

justinmc · 2026-08-07T16:42:58Z

    'examples/api/test/ui/text/font_feature.font_feature_subscripts.0_test.dart',
    'examples/api/test/ui/text/font_feature.font_feature_character_variant.0_test.dart',
    'examples/api/lib/widgets/animated_grid/sliver_animated_grid.0.dart',
+    'examples/api/lib/widgets/expansible/expansible.0.dart',


When I enabled the script, the analyzer failed because these files have cross imports in them. Did we somehow miss these in your initial PR because it wasn't running in CI?

dkwingsmt

LGTM. Thank you!

…#12453) Manual roll Flutter from 27b098811f3b to c2437523d308 (179 revisions) Manual roll requested by tarrinneal@google.com flutter/flutter@27b0988...c243752 2026-08-12 matt.boetger@gmail.com Enable Gradle CI cache on all test targets that require android_sdk (flutter/flutter#190723) 2026-08-12 bkonyi@google.com [analysis] Reland "Added initial implementation of the flutter_analyzer_plugin (#175679)" (flutter/flutter#191022) 2026-08-12 matt.boetger@gmail.com Switch testing to gradle bin distribution type instead of all (flutter/flutter#190738) 2026-08-12 matt.boetger@gmail.com Convert Mockito instances in Kotlin to Mockk (flutter/flutter#189884) 2026-08-12 chingjun@google.com Report individual test results to LUCI ResultDB (flutter/flutter#190254) 2026-08-12 victorsanniay@gmail.com Toggleable reaction duration respects overrides (flutter/flutter#190857) 2026-08-12 engine-flutter-autoroll@skia.org Roll Skia from e00dbd7448c4 to fee7272f5bc2 (1 revision) (flutter/flutter#191007) 2026-08-12 30870216+gaaclarke@users.noreply.github.com Started caching text shadows by content. (flutter/flutter#190681) 2026-08-12 30870216+gaaclarke@users.noreply.github.com Adds agent skill for spawning led tasks. (flutter/flutter#190937) 2026-08-12 engine-flutter-autoroll@skia.org Roll Packages from aaaf246 to 94485f1 (8 revisions) (flutter/flutter#191008) 2026-08-12 82978131+herdiyana256@users.noreply.github.com flutter_tools: validate plugin identifiers before generating registrant code (flutter/flutter#190462) 2026-08-12 engine-flutter-autoroll@skia.org Roll Skia from 112f36148949 to e00dbd7448c4 (3 revisions) (flutter/flutter#190993) 2026-08-12 engine-flutter-autoroll@skia.org Roll Skia from 7d366c802307 to 112f36148949 (3 revisions) (flutter/flutter#190983) 2026-08-12 okorohelijah@google.com remove bringup for flavors test (flutter/flutter#190940) 2026-08-12 engine-flutter-autoroll@skia.org Roll Skia from 1f10a20bdd61 to 7d366c802307 (2 revisions) (flutter/flutter#190980) 2026-08-12 116356835+AbdeMohlbi@users.noreply.github.com Remove `--no-sim-use-hardfp` flag (flutter/flutter#190790) 2026-08-12 137456488+flutter-pub-roller-bot@users.noreply.github.com Roll pub packages (flutter/flutter#190977) 2026-08-12 engine-flutter-autoroll@skia.org Roll Skia from 339bedab6766 to 1f10a20bdd61 (1 revision) (flutter/flutter#190975) 2026-08-12 victorsanniay@gmail.com RawTooltip respects AnimationStyle updates and reverseCurve (flutter/flutter#190889) 2026-08-12 chris@bracken.jp ci: Support --target_arch option in prepare_package.dart (flutter/flutter#190960) 2026-08-12 engine-flutter-autoroll@skia.org Roll Fuchsia Linux SDK from SFq4FVodIOQAS26Lr... to -uHuSGv3wt7QAlDwa... (flutter/flutter#190973) 2026-08-12 aam@google.com Removes building of ci/android_debug_x86 as nobody should be consuming it. (flutter/flutter#190951) 2026-08-12 30870216+gaaclarke@users.noreply.github.com Adds error about wimp_heavy not being implemented. (flutter/flutter#189945) 2026-08-11 robert.ancell@canonical.com Add clang, cmake, and ninja deps to Linux windowing_test (flutter/flutter#190119) 2026-08-11 269567208+reidbaker-agent@users.noreply.github.com [AGP 9.1.0 Migration #1] Add Android Gradle Plugin Public API migration documentation (flutter/flutter#190842) 2026-08-11 bkonyi@google.com [flutter_tools] Fix deadlock in debug adapters when process exits early (flutter/flutter#190931) 2026-08-11 bkonyi@google.com [tool] Define modular dependency injection containers and bootstrapper (flutter/flutter#190724) 2026-08-11 1961493+harryterkelsen@users.noreply.github.com [web] Unify MaskFilter and ColorFilter primitives across CanvasKit and Skwasm (flutter/flutter#190314) 2026-08-11 137456488+flutter-pub-roller-bot@users.noreply.github.com Roll pub packages (flutter/flutter#190958) 2026-08-11 33794642+FelixMittermeier@users.noreply.github.com [Impeller] Move image upload scheduling waits to GPU disable (flutter/flutter#190445) 2026-08-11 30870216+gaaclarke@users.noreply.github.com Started generating the windows platform for macrobenchmarks (flutter/flutter#190932) 2026-08-11 1961493+harryterkelsen@users.noreply.github.com [web] Unify ui.Vertices (flutter/flutter#190563) 2026-08-11 jhy03261997@gmail.com Fix accessibility_inspector service extensions map mutability (flutter/flutter#190888) 2026-08-11 47866232+chunhtai@users.noreply.github.com Add batch3 a11y_assessment for vpat (flutter/flutter#189042) 2026-08-11 15619084+vashworth@users.noreply.github.com Remove Xcode environment when building swift tools in Xcode pre-action (flutter/flutter#190848) 2026-08-11 mdebbar@google.com [tool] Add missing play element in web test index.html to fix warning (flutter/flutter#190675) 2026-08-11 kkmk1999@gmail.com Offload blocking work in ProcessTextPlugin to the background (flutter/flutter#189823) 2026-08-11 bkonyi@google.com [flutter_tools] Replace usages of package:dds/dap.dart with package:dap_adapters/dap_adapters.dart (flutter/flutter#190667) 2026-08-11 15619084+vashworth@users.noreply.github.com Always update swift package dependencies (flutter/flutter#190886) 2026-08-11 bkonyi@google.com [flutter_tools] Add --preset option to flutter test (flutter/flutter#190878) 2026-08-11 jmccandless@google.com Include the examples cross imports checker in the analzyer. (flutter/flutter#190674) 2026-08-11 bkonyi@google.com [devicelab] Remove orphaned screenshot test files (flutter/flutter#190879) 2026-08-11 jason-simmons@users.noreply.github.com Remove the bringup flag from the linux_arm_host_desktop_engine builder (flutter/flutter#190935) 2026-08-11 mdebbar@google.com Reduce web_skwasm_tests subshards from 8 to 2 (flutter/flutter#190728) ...

Include the examples cross imports checker in the analzyer.

3e67c09

We forgot to do this when it was first landed.

justinmc requested a review from navaronbracke August 6, 2026 18:19

flutter-dashboard Bot added the CICD Run CI/CD label Aug 6, 2026

gemini-code-assist Bot reviewed Aug 6, 2026

View reviewed changes

Remove multiple_windows example from knowns; it has already been migr…

c2d4c13

…ated

navaronbracke previously approved these changes Aug 6, 2026

View reviewed changes

justinmc dismissed navaronbracke’s stale review via c2d4c13 August 6, 2026 19:55

Add missing known imports

ca6a335

justinmc requested review from QuncCccccc, Renzo-Olivares, dkwingsmt and elliette August 6, 2026 23:03

justinmc commented Aug 6, 2026

View reviewed changes

navaronbracke reviewed Aug 7, 2026

View reviewed changes

justinmc commented Aug 7, 2026

View reviewed changes

elliette previously approved these changes Aug 7, 2026

View reviewed changes

dkwingsmt previously approved these changes Aug 7, 2026

View reviewed changes

Merge branch 'master' into cross-imports-examples-checker-activation

fa256ed

justinmc dismissed stale reviews from dkwingsmt and elliette via fa256ed August 7, 2026 23:00

Fix order

392e748

dkwingsmt previously approved these changes Aug 7, 2026

View reviewed changes

justinmc added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 10, 2026

auto-submit Bot added this pull request to the merge queue Aug 10, 2026

github-merge-queue Bot removed this pull request from the merge queue due to a conflict with the base branch Aug 11, 2026

flutter-dashboard Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Aug 11, 2026

Merge branch 'master' into cross-imports-examples-checker-activation

5f88029

justinmc dismissed dkwingsmt’s stale review via 5f88029 August 11, 2026 18:05

justinmc requested a review from dkwingsmt August 11, 2026 18:05

justinmc requested a review from elliette August 11, 2026 18:05

dkwingsmt approved these changes Aug 11, 2026

View reviewed changes

justinmc added the autosubmit Merge PR when tree becomes green via auto submit App label Aug 11, 2026

navaronbracke approved these changes Aug 11, 2026

View reviewed changes

auto-submit Bot added this pull request to the merge queue Aug 11, 2026

Merged via the queue into flutter:master with commit d794caa Aug 11, 2026
22 checks passed

flutter-dashboard Bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Aug 11, 2026

This was referenced Aug 12, 2026

Manual roll Flutter from 27b098811f3b to cad30545bda6 (153 revisions) flutter/packages#12441

Closed

Roll Flutter from 27b098811f3b to fcefd402c65e (168 revisions) flutter/packages#12443

Closed

justinmc deleted the cross-imports-examples-checker-activation branch August 12, 2026 15:24

Navigation Menu

Uh oh!

Include the examples cross imports checker in the analzyer. - #190674

Include the examples cross imports checker in the analzyer.#190674
auto-submit[bot] merged 6 commits into
flutter:masterfrom
justinmc:cross-imports-examples-checker-activation

justinmc commented Aug 6, 2026

Uh oh!

gemini-code-assist Bot left a comment

Uh oh!

navaronbracke left a comment

Uh oh!

justinmc commented Aug 6, 2026

Uh oh!

justinmc Aug 6, 2026

Uh oh!

navaronbracke Aug 7, 2026

Uh oh!

justinmc Aug 7, 2026

Uh oh!

dkwingsmt Aug 7, 2026

Uh oh!

justinmc Aug 7, 2026

Uh oh!

justinmc Aug 6, 2026

Uh oh!

justinmc Aug 7, 2026

Uh oh!

dkwingsmt left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

justinmc commented Aug 6, 2026

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

navaronbracke left a comment

Choose a reason for hiding this comment

Uh oh!

justinmc commented Aug 6, 2026

Uh oh!

justinmc Aug 6, 2026

Choose a reason for hiding this comment

Uh oh!

navaronbracke Aug 7, 2026

Choose a reason for hiding this comment

Uh oh!

justinmc Aug 7, 2026

Choose a reason for hiding this comment

Uh oh!

dkwingsmt Aug 7, 2026

Choose a reason for hiding this comment

Uh oh!

justinmc Aug 7, 2026

Choose a reason for hiding this comment

Uh oh!

justinmc Aug 6, 2026

Choose a reason for hiding this comment

Uh oh!

justinmc Aug 7, 2026

Choose a reason for hiding this comment

Uh oh!

dkwingsmt left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants