Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Question: is plugins repo acceptable kotlin/swift ? #17999

Closed
azihsoyn opened this issue May 29, 2018 · 4 comments
Closed

Question: is plugins repo acceptable kotlin/swift ? #17999

azihsoyn opened this issue May 29, 2018 · 4 comments
Labels
package flutter/packages repository. See also p: labels.

Comments

@azihsoyn
Copy link

Hi, I love flutter.

I found flutter plugins repo is only obj-c, Java code for native implementation.

Can I use swift/kotlin for PR?

Thanks.
@goderbauer
Copy link
Member

@mravn-google

@mravn-google
Copy link
Contributor

mravn-google commented May 30, 2018 •
edited
Loading

AFAIK, Swift currently comes with a substantial overhead to the consuming app. Kotlin less so, and adding some proguard rules may get rid of most of it.

Anyway, app bundles (apk/ipa) built from projects created using

flutter -i objc -a java create old_school
flutter -i swift -a kotlin create new_kid

have the following sizes:

Java apk:     7.3MB
Kotlin apk:   7.7MB
ObjC ipa:    49.5MB
Swift ipa:  187.2MB

These sizes may not mean much, but it does seem to me that the decision of whether to use Kotlin and Swift should be taken by the app author, not the plugin author.

@azihsoyn
Copy link
Author

Thank you for answering!

I will support your opinion.

Best regards.

@long1eu long1eu mentioned this issue Aug 22, 2018
Closed
@truongsinh truongsinh mentioned this issue Dec 15, 2018
Closed
@long1eu long1eu mentioned this issue Jan 1, 2019
Closed
@long1eu long1eu mentioned this issue Feb 5, 2019
Closed
@long1eu long1eu mentioned this issue Mar 5, 2019
Closed
christopherfujino added a commit to christopherfujino/flutter that referenced this issue Apr 28, 2020
@christopherfujino
git log 4bcfae8..0c35a34 --oneline --first-parent
6885302 
0c35a34 Roll src/third_party/skia f5132a05c893..4baa7326ccfb (1 commits) (flutter#18003)
f07712b Roll src/third_party/skia 5f56cb1d3b4f..f5132a05c893 (6 commits) (flutter#17999)
103c9c7 Bumped up the timeout for testAccessibilityFocusOnTextSemanticsProducesCorrectIosViews (flutter#17988)
a1fdff6 Roll src/third_party/skia 81ef385c1fcd..5f56cb1d3b4f (14 commits) (flutter#17991)
22479ca Roll Dart to 726d3c772554924f62db0b9e0d4c280dbbddc824 (flutter#17993)
494a63c Trial PR to enable null safety unfork in the Dart SDK. (flutter#17818)
887efcb Roll fuchsia/sdk/core/linux-amd64 from eapIV... to 3h-X9... (flutter#17987)
50ae2b9 Set SkSL asset manager in RunConfiguration ctor (flutter#17948)
5f437fb Started ignoring remote keyboard notifications. (flutter#17981)
027eff8 Reenable flutter scenic test to identify crashes and follow up on fixes. (flutter#17979)
992a55c Update buildroot (flutter#17978)
d5587df Roll src/third_party/skia 78debd6f6d83..81ef385c1fcd (1 commits) (flutter#17976)
aa00d50 [web] Don't allow empty initial route (flutter#17936)
3b0e415 Roll fuchsia/sdk/core/mac-amd64 from 9O3Ef... to arZdZ... (flutter#17975)
66af9ea Roll src/third_party/skia 981d590e8eba..78debd6f6d83 (5 commits) (flutter#17972)
732bf22 Manual roll of Dart to 03429b20cd67f85d65cc589b529ab8c1a4780912...a53d336b9fd4bbb415d2f1e3f4c653aa107f31c7 (flutter#17971)
cad81c7 Roll src/third_party/skia 1ae3e75a0b4c..981d590e8eba (1 commits) (flutter#17968)
eed05dd Add initial unit tests for the android embedding (flutter#17921)
168a65f Roll src/third_party/dart 2e438d1baffc..a53d336b9fd4 (4 commits) (flutter#17967)
742adb8 Roll src/third_party/skia 97cfb05aabe4..1ae3e75a0b4c (2 commits) (flutter#17966)
805ef7c Roll fuchsia/sdk/core/mac-amd64 from 2CE6x... to 9O3Ef... (flutter#17963)
11c6a18 Roll src/third_party/skia c12aad9485a9..97cfb05aabe4 (3 commits) (flutter#17957)
4e29e57 Roll fuchsia/sdk/core/mac-amd64 from 9-v-E... to 2CE6x... (flutter#17955)
4f3b929 Roll src/third_party/dart 216e3df4526c..2e438d1baffc (7 commits) (flutter#17950)
4f888d6 Change the repo fetch script used in integration tests (flutter#17943)
3999ef9 Roll src/third_party/skia 1e21d14f2b8b..c12aad9485a9 (20 commits) (flutter#17942)
d01de3b Roll src/third_party/dart a69cb6d700f5..216e3df4526c (16 commits) (flutter#17945)
2589d07 Fix accessibility focus loss when first focusing on text field (flutter#17803)
3af2b1a Roll fuchsia/sdk/core/linux-amd64 from _dAFU... to G4HpJ... (flutter#17938)
d132ac5 [web] Fix exception when getting boxes for rich text range (flutter#17933)
cade0e9 [web] Batch systemFontChange messages (flutter#17885)
@christopherfujino christopherfujino mentioned this issue Apr 28, 2020
Merged
christopherfujino added a commit that referenced this issue Apr 28, 2020
@christopherfujino
git log 4bcfae8..0c35a34 --oneline --first-parent (#55891)
8cbba0a 
0c35a34 Roll src/third_party/skia f5132a05c893..4baa7326ccfb (1 commits) (#18003)
f07712b Roll src/third_party/skia 5f56cb1d3b4f..f5132a05c893 (6 commits) (#17999)
103c9c7 Bumped up the timeout for testAccessibilityFocusOnTextSemanticsProducesCorrectIosViews (#17988)
a1fdff6 Roll src/third_party/skia 81ef385c1fcd..5f56cb1d3b4f (14 commits) (#17991)
22479ca Roll Dart to 726d3c772554924f62db0b9e0d4c280dbbddc824 (#17993)
494a63c Trial PR to enable null safety unfork in the Dart SDK. (#17818)
887efcb Roll fuchsia/sdk/core/linux-amd64 from eapIV... to 3h-X9... (#17987)
50ae2b9 Set SkSL asset manager in RunConfiguration ctor (#17948)
5f437fb Started ignoring remote keyboard notifications. (#17981)
027eff8 Reenable flutter scenic test to identify crashes and follow up on fixes. (#17979)
992a55c Update buildroot (#17978)
d5587df Roll src/third_party/skia 78debd6f6d83..81ef385c1fcd (1 commits) (#17976)
aa00d50 [web] Don't allow empty initial route (#17936)
3b0e415 Roll fuchsia/sdk/core/mac-amd64 from 9O3Ef... to arZdZ... (#17975)
66af9ea Roll src/third_party/skia 981d590e8eba..78debd6f6d83 (5 commits) (#17972)
732bf22 Manual roll of Dart to 03429b20cd67f85d65cc589b529ab8c1a4780912...a53d336b9fd4bbb415d2f1e3f4c653aa107f31c7 (#17971)
cad81c7 Roll src/third_party/skia 1ae3e75a0b4c..981d590e8eba (1 commits) (#17968)
eed05dd Add initial unit tests for the android embedding (#17921)
168a65f Roll src/third_party/dart 2e438d1baffc..a53d336b9fd4 (4 commits) (#17967)
742adb8 Roll src/third_party/skia 97cfb05aabe4..1ae3e75a0b4c (2 commits) (#17966)
805ef7c Roll fuchsia/sdk/core/mac-amd64 from 2CE6x... to 9O3Ef... (#17963)
11c6a18 Roll src/third_party/skia c12aad9485a9..97cfb05aabe4 (3 commits) (#17957)
4e29e57 Roll fuchsia/sdk/core/mac-amd64 from 9-v-E... to 2CE6x... (#17955)
4f3b929 Roll src/third_party/dart 216e3df4526c..2e438d1baffc (7 commits) (#17950)
4f888d6 Change the repo fetch script used in integration tests (#17943)
3999ef9 Roll src/third_party/skia 1e21d14f2b8b..c12aad9485a9 (20 commits) (#17942)
d01de3b Roll src/third_party/dart a69cb6d700f5..216e3df4526c (16 commits) (#17945)
2589d07 Fix accessibility focus loss when first focusing on text field (#17803)
3af2b1a Roll fuchsia/sdk/core/linux-amd64 from _dAFU... to G4HpJ... (#17938)
d132ac5 [web] Fix exception when getting boxes for rich text range (#17933)
cade0e9 [web] Batch systemFontChange messages (#17885)
@github-actions
Copy link

github-actions bot commented Sep 3, 2021

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug, including the output of flutter doctor -v and a minimal reproduction of the issue.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 3, 2021
@flutter-triage-bot flutter-triage-bot bot added the package flutter/packages repository. See also p: labels. label Jul 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
package flutter/packages repository. See also p: labels.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@azihsoyn @goderbauer @mravn-google