This repository was archived by the owner on Feb 25, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 6k
Allow creating views from an external engine #54080
Merged
robert-ancell
merged 2 commits into
flutter:main
from
robert-ancell:linux-extract-engine-from-view
Jul 25, 2024
Merged
Allow creating views from an external engine #54080
robert-ancell
merged 2 commits into
flutter:main
from
robert-ancell:linux-extract-engine-from-view
Jul 25, 2024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Set everything up in the construction function, instead using properties and a constructed vfunc. While this is the pure GObject way of doing things we haven't done it in any other classes in Flutter and it is more complex than doing it all in one function. We no longer need to keep the project ref in the FlView which is never used beyond construction.
While only one view works at this point in the future this will allow a runner to create multiple views.
cbracken
approved these changes
Jul 24, 2024
Member
cbracken
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jul 25, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Jul 25, 2024
…152314) flutter/engine@7473782...f47b4d8 2024-07-25 [email protected] Roll Skia from 9942b4423e4d to 75994403a8a4 (1 revision) (flutter/engine#54108) 2024-07-25 [email protected] Roll Dart SDK from 8389a7bb94f4 to a9eb9553033c (1 revision) (flutter/engine#54107) 2024-07-25 [email protected] Roll Fuchsia Linux SDK from qA7S-DZ5FyMtcM7_J... to pkL7F9aPLbFBRhsoL... (flutter/engine#54103) 2024-07-25 [email protected] Roll Skia from 746d444f3efd to 9942b4423e4d (4 revisions) (flutter/engine#54104) 2024-07-25 [email protected] Allow creating views from an external engine (flutter/engine#54080) 2024-07-25 [email protected] Support multiple views in FlRenderer (flutter/engine#54072) 2024-07-25 [email protected] Roll Dart SDK from 693848f200d7 to 8389a7bb94f4 (1 revision) (flutter/engine#54100) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from qA7S-DZ5FyMt to pkL7F9aPLbFB If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
TytaniumDev
pushed a commit
to TytaniumDev/flutter
that referenced
this pull request
Aug 7, 2024
…lutter#152314) flutter/engine@7473782...f47b4d8 2024-07-25 [email protected] Roll Skia from 9942b4423e4d to 75994403a8a4 (1 revision) (flutter/engine#54108) 2024-07-25 [email protected] Roll Dart SDK from 8389a7bb94f4 to a9eb9553033c (1 revision) (flutter/engine#54107) 2024-07-25 [email protected] Roll Fuchsia Linux SDK from qA7S-DZ5FyMtcM7_J... to pkL7F9aPLbFBRhsoL... (flutter/engine#54103) 2024-07-25 [email protected] Roll Skia from 746d444f3efd to 9942b4423e4d (4 revisions) (flutter/engine#54104) 2024-07-25 [email protected] Allow creating views from an external engine (flutter/engine#54080) 2024-07-25 [email protected] Support multiple views in FlRenderer (flutter/engine#54072) 2024-07-25 [email protected] Roll Dart SDK from 693848f200d7 to 8389a7bb94f4 (1 revision) (flutter/engine#54100) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from qA7S-DZ5FyMt to pkL7F9aPLbFB If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Buchimi
pushed a commit
to Buchimi/flutter
that referenced
this pull request
Sep 2, 2024
…lutter#152314) flutter/engine@7473782...f47b4d8 2024-07-25 [email protected] Roll Skia from 9942b4423e4d to 75994403a8a4 (1 revision) (flutter/engine#54108) 2024-07-25 [email protected] Roll Dart SDK from 8389a7bb94f4 to a9eb9553033c (1 revision) (flutter/engine#54107) 2024-07-25 [email protected] Roll Fuchsia Linux SDK from qA7S-DZ5FyMtcM7_J... to pkL7F9aPLbFBRhsoL... (flutter/engine#54103) 2024-07-25 [email protected] Roll Skia from 746d444f3efd to 9942b4423e4d (4 revisions) (flutter/engine#54104) 2024-07-25 [email protected] Allow creating views from an external engine (flutter/engine#54080) 2024-07-25 [email protected] Support multiple views in FlRenderer (flutter/engine#54072) 2024-07-25 [email protected] Roll Dart SDK from 693848f200d7 to 8389a7bb94f4 (1 revision) (flutter/engine#54100) Also rolling transitive DEPS: fuchsia/sdk/core/linux-amd64 from qA7S-DZ5FyMt to pkL7F9aPLbFB If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.

While only one view works at this point in the future this will allow a runner to create multiple views.
To make use of this the runner template would have the following changes: