Simplify the FlView constructor #54078
Conversation
Set everything up in the construction function, instead using properties and a constructed vfunc. While this is the pure GObject way of doing things we haven't done it in any other classes in Flutter and it is more complex than doing it all in one function. We no longer need to keep the project ref in the FlView which is never used beyond construction.
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact "@test-exemption-reviewer" in the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
|
This is also motivated by simplifying this code to support multi-view which will share an engine between views. |
|
test-exempt: code refactor with no semantic change |
|
Was merged in #54080 (this should have been merged first). |
3 participants
Set everything up in the construction function, instead using properties and a constructed vfunc. While this is the pure GObject way of doing things we haven't done it in any other classes in Flutter and it is more complex than doing it all in one function. We no longer need to keep the project ref in the FlView which is never used beyond construction.