This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Avoid non-const sizes in VLAs. #48693
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I was shocked this was even legal earlier. But a new Clang roll makes this an a warning which gets converted into an error. I attempted to roll to the Clang roll the roller did and fixed the issues I found. Hopefully, the next roll is unblocked. Original failure: flutter#48563
zanderso
approved these changes
Dec 5, 2023
chinmaygarde
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 5, 2023
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Dec 5, 2023
flutter/engine@9660439...c49b861 2023-12-05 [email protected] Avoid non-const sizes in VLAs. (flutter/engine#48693) 2023-12-05 [email protected] [Impeller] Prefer moving vertex buffer, place on command instead of binding object. (flutter/engine#48630) 2023-12-05 [email protected] Roll Skia from c759bbf16310 to 5f54e9f84cff (3 revisions) (flutter/engine#48692) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
chinmaygarde
added a commit
to chinmaygarde/flutter_engine
that referenced
this pull request
Dec 5, 2023
Previously attempted by flutter#48563 but failed because of fixes needed in flutter#48693
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was shocked this was even legal earlier. But a new Clang roll makes this an a warning which gets converted into an error.
I attempted to roll to the Clang roll the roller did and fixed the issues I found. Hopefully, the next roll is unblocked.
Original failure: #48563