This repository was archived by the owner on Feb 25, 2025. It is now read-only.
[Impeller] Prefer moving vertex buffer, place on command instead of binding object. #48630
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonahwilliams
commented
Dec 4, 2023
Comment on lines
-437
to
-441
| if (command.vertex_count == 0u) { | ||
| continue; | ||
| } | ||
| if (command.instance_count == 0u) { | ||
| continue; |
Contributor
Author
There was a problem hiding this comment.
This is already checked in render_pass.cc
jonahwilliams
commented
Dec 4, 2023
| PassBindingsCache& command_buffer_cache, | ||
| const ISize& target_size, | ||
| const vk::DescriptorSet vk_desc_set) { | ||
| if (command.vertex_count == 0u || command.instance_count == 0u) { |
Contributor
Author
There was a problem hiding this comment.
This is already checked in render_pass.cc
jonahwilliams
commented
Dec 4, 2023
| SampledImageSlot slot; | ||
| TextureResource texture; | ||
| SamplerResource sampler; | ||
| std::shared_ptr<const Sampler> sampler; |
Contributor
Author
There was a problem hiding this comment.
We don't need a Resource wrapper for the sampler since we only support combined image+sampler.
chinmaygarde
changed the title
jonahwilliams
commented
Dec 5, 2023
| std::shared_ptr<const Texture> texture, | ||
| std::shared_ptr<const Sampler> sampler) override; | ||
|
|
||
| BufferView GetVertexBuffer() const; |
Contributor
Author
There was a problem hiding this comment.
This isn't really that useful so I removed it.
Contributor
Author
|
FYI. I've been trying to make more types move only. What I've found is that if we have any user defined constructors then we can't use the aggregate initialization syntax, so no I'd be tempted to go back and make Command move only, but BufferView and VertexBuffer feels bad man. |
matanlurey
approved these changes
Dec 5, 2023
Contributor
matanlurey
left a comment
matanlurey
left a comment
There was a problem hiding this comment.
LGTM as mostly trivial
jonahwilliams
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 5, 2023
…ead of binding object. (flutter/engine#48630)
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Dec 5, 2023
…139595) flutter/engine@9660439...c49b861 2023-12-05 [email protected] Avoid non-const sizes in VLAs. (flutter/engine#48693) 2023-12-05 [email protected] [Impeller] Prefer moving vertex buffer, place on command instead of binding object. (flutter/engine#48630) 2023-12-05 [email protected] Roll Skia from c759bbf16310 to 5f54e9f84cff (3 revisions) (flutter/engine#48692) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Placing the vertex buffer on the binding object meant that we were actually paying 2x the size cost for it (one for vertex bindings, one for fragment bindings). By moving this object onto command itself, we reduce the size and avoid spliting up the command state in a weird way.
Also updates most of the contents to prefer moving the VertexBuffer.