This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Run Flutter platform tasks in GLib main loop #17910
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robert-ancell
changed the title
robert-ancell
force-pushed
the
linux-shell-platform-tasks
branch
from
2fda348 to
4d27d3b
Compare
Contributor
Author
|
Builds on #17363, which is ready to land once LUCI is happy. |
robert-ancell
force-pushed
the
linux-shell-platform-tasks
branch
from
4d27d3b to
0560da6
Compare
Contributor
Author
chinmaygarde
approved these changes
Apr 24, 2020
stuartmorgan-g
suggested changes
Apr 27, 2020
stuartmorgan-g
suggested changes
Apr 27, 2020
Contributor
stuartmorgan-g
left a comment
stuartmorgan-g
left a comment
There was a problem hiding this comment.
Setting back to "request changes". @chinmaygarde I think you cleared my review instead of yours.
robert-ancell
force-pushed
the
linux-shell-platform-tasks
branch
from
0560da6 to
2c62f30
Compare
Contributor
Author
|
Thanks for reviews @chinmaygarde @stuartmorgan, all issues should be resolved now. |
robert-ancell
force-pushed
the
linux-shell-platform-tasks
branch
from
2c62f30 to
814bb86
Compare
stuartmorgan-g
approved these changes
Apr 28, 2020
Contributor
stuartmorgan-g
left a comment
stuartmorgan-g
left a comment
There was a problem hiding this comment.
LGTM (with the caveat that I'm not familiar with the GTK portion of this API, so if there's a subtle bug there I'm definitely not going to have caught it)
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 28, 2020
fluttergithubbot
pushed a commit
to flutter/flutter
that referenced
this pull request
Apr 29, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 5, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.