This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Refactor FlutterEngine usage in Linux shell #17363
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
robert-ancell
force-pushed
the
linux-shell-fl-engine
branch
2 times, most recently
from
1b90a0f to
dc930a4
Compare
robert-ancell
force-pushed
the
linux-shell-fl-engine
branch
3 times, most recently
from
3b227b0 to
3a1ff03
Compare
robert-ancell
force-pushed
the
linux-shell-fl-engine
branch
3 times, most recently
from
cf53d93 to
c80e405
Compare
stuartmorgan-g
suggested changes
Apr 21, 2020
robert-ancell
force-pushed
the
linux-shell-fl-engine
branch
2 times, most recently
from
d2944ef to
8c6f84e
Compare
Contributor
Author
|
Should be good for another review @stuartmorgan |
stuartmorgan-g
suggested changes
Apr 22, 2020
Contributor
stuartmorgan-g
left a comment
stuartmorgan-g
left a comment
There was a problem hiding this comment.
Just one more structural comment on the class structure, the rest is minor nits. Overall this looks great, and is definitely a big step away from the mess the GLFW embedding evolved into :)
robert-ancell
force-pushed
the
linux-shell-fl-engine
branch
4 times, most recently
from
39a3883 to
cdf3427
Compare
robert-ancell
force-pushed
the
linux-shell-fl-engine
branch
from
cdf3427 to
a0ca0e1
Compare
This was referenced Apr 23, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 24, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Apr 24, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This refactor pulls the engine code out of the GTK widget into its own class. There is an X11 implementation now used by the widget, and we will be able to develop a Wayland implementation in the future.
This depends on #17302.