This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Adjust newline rectangles to reflect paragraph alignment #17744
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GetRectsForRange inserts empty rectangles that represent newline characters within the specified range of text positions. The x coordinate of these rectangles needs to account for left/right/center alignment. Fixes flutter/flutter#53057
Contributor
|
This PR has problems with RTL because it places the caret on the glyph_line's end on the newline and that means the line's start on an RTL line. |
Contributor
|
I made another PR based on this one that also handles direction #17750 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GetRectsForRange inserts empty rectangles that represent newline
characters within the specified range of text positions. The
x coordinate of these rectangles needs to account for left/right/center
alignment.
Fixes flutter/flutter#53057