Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@DeMonkeyCoder
Copy link
Contributor

fixed issue flutter/flutter#53057

@DeMonkeyCoder
Copy link
Contributor Author

DeMonkeyCoder commented Apr 13, 2020

I couldn't find documentation for running test files on the engine.
I think it would be better if you add it to your contribution guide.

@DeMonkeyCoder
Copy link
Contributor Author

@GaryQian @justinmc

@justinmc
Copy link
Contributor

I tried running this locally and it improves the situation, but I still see a problem:

To reproduce:

  1. Create a multiline input with textAlign: TextAlign.right.
  2. Type some text on the first line.
  3. Hit return to go to the second line and type some text there.
  4. Press the up arrow.
  5. Type more text. The cursor appears on the left but text is inserted on the right.

@jason-simmons
Copy link
Member

Thank you for the PR, and sorry for taking so long to review it.

I looked at this bug and posted a PR with a solution that I believe will work for all text alignment modes. See #17744

@DeMonkeyCoder
Copy link
Contributor Author

Thanks for your review.
So I'm closing this one.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants