Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@mikejurka
Copy link
Contributor

A previous version of this change also removed
system compositing of PhysicalShapeLayers on
Fuchsia. In this reland, keep using system
composting for PhysicalShapeLayers.

@mikejurka
Copy link
Contributor Author

mikejurka commented Dec 19, 2019

This should be identical to ea67e5b except without the changes to PhysicalShapeLayer, and one merge conflict when applying this to master.

This line was added to OpacityLayer::Preroll by Jim in 8595361, and I added it to this CL too:

Layer::AutoPrerollSaveLayerState save =
      Layer::AutoPrerollSaveLayerState::Create(context);

Copy link
Contributor

@iskakaushik iskakaushik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@flar
Copy link
Contributor

flar commented Dec 19, 2019

I didn't have time to review everything here, but I verified that you maintained the PrerollSaveLayerState code that I added. Thanks!

FWIW, LGTM.

A previous version of this change also removed
system compositing of PhysicalShapeLayers on
Fuchsia. In this reland, keep using system
composting for PhysicalShapeLayers.
@mikejurka
Copy link
Contributor Author

mikejurka commented Dec 19, 2019

I think I figured out the flashing issue. Changed opacity_layer.cc:69 from:

if (OpacityLayerBase::can_system_composite()) {
    set_dimensions(SkRRect::MakeRect(paint_bounds()));
    set_needs_system_composite(true);
  } else {

to:

if (OpacityLayerBase::can_system_composite() && needs_system_composite()) {
    set_dimensions(SkRRect::MakeRect(paint_bounds()));
  } else {

@mikejurka mikejurka merged commit 1f7bb9d into flutter:master Dec 19, 2019
@mikejurka mikejurka deleted the opacity_latest branch December 19, 2019 22:25
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 20, 2019
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 20, 2019
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 20, 2019
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 20, 2019
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 20, 2019
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 20, 2019
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 20, 2019
flar pushed a commit to flutter/flutter that referenced this pull request Dec 20, 2019
* bb118c6 Roll src/third_party/dart 8d11c1dce64a..642f8d052fd7 (1 commits) (flutter/engine#14574)

* 09c434d Use ELF for Dart AOT snapshots on Fuchsia. (flutter/engine#13896)

* e1e7851 Roll fuchsia/sdk/core/linux-amd64 from VdBKA... to uFFWW... (flutter/engine#14575)

* f317f8f Roll src/third_party/skia c76ac8e325c7..77742c350371 (1 commits) (flutter/engine#14576)

* 2ba5633 instructions for running firefox/safari tests (flutter/engine#14562)

* 9cf1e46 Roll src/third_party/dart 642f8d052fd7..7113fc79a83c (3 commits) (flutter/engine#14578)

* f5b877a [web] Run engine tests on Safari locally by launching safari installed on MacOS (flutter/engine#14555)

* 68d9196 Fix DOM-based ParagraphRuler.hitTest() (flutter/engine#14504)

* bb65df8 Roll src/third_party/skia 77742c350371..a8352ccaae37 (8 commits) (flutter/engine#14579)

* ad1ab56 Roll src/third_party/dart 7113fc79a83c..e50d98cd5651 (8 commits) (flutter/engine#14580)

* 22413ef Update formatting in web_ui scene bulder to match flutter style and dartfmt. (flutter/engine#14539)

* 6e825e7 Roll fuchsia/sdk/core/mac-amd64 from Ykb4b... to f51Q_... (flutter/engine#14584)

* 1d3bb8c Fix message_loop_fuchsia and thus enable fml_tests and flow_tests for Fuchsia (flutter/engine#14583)

* 1f7bb9d Wire up OpacityLayer to Scenic (flutter/engine#14577)

* 11db035 Roll src/third_party/skia a8352ccaae37..87e9ddb675b6 (11 commits) (flutter/engine#14585)

* bd58af7 Roll src/third_party/dart e50d98cd5651..141fcfa61092 (3 commits) (flutter/engine#14586)

* 929b1ed Engine support for ImageFiltered widget (flutter/engine#14491)

* 40b84fc Fix lint warnings across web_ui, add missing browserEngine case in text field. (flutter/engine#14535)

* ea1d330 Roll fuchsia/sdk/core/linux-amd64 from uFFWW... to 25LzW... (flutter/engine#14587)

* 854d5f8 Roll src/third_party/skia 87e9ddb675b6..7e2dea568299 (1 commits) (flutter/engine#14589)
filmil pushed a commit to filmil/engine that referenced this pull request Mar 13, 2020
A previous version of this change also removed
system compositing of PhysicalShapeLayers on
Fuchsia. In this reland, keep using system
composting for PhysicalShapeLayers.

Co-authored-by: David Worsham <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants