Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Engine support for ImageFiltered widget #14491

Merged
flar merged 8 commits into from
Dec 20, 2019
Merged

Engine support for ImageFiltered widget #14491

flar merged 8 commits into from
Dec 20, 2019

Conversation

@flar
Copy link
Contributor

@flar flar commented Dec 14, 2019

Supports potential Flutter ImageFiltered widget as per flutter/flutter#13489

@flar flar requested review from arbreng, liyuqian and yjbanov December 14, 2019 01:55
@auto-assign auto-assign bot requested a review from chinmaygarde December 14, 2019 01:55
@flar
Copy link
Contributor Author

flar commented Dec 14, 2019

Associated Framework commit waiting for this PR to land: https://github.com/flar/flutter/tree/imagefiltered-widget

@flar flar mentioned this pull request Dec 16, 2019
Closed
liyuqian
liyuqian reviewed Dec 16, 2019
View reviewed changes
Copy link
Contributor

@liyuqian liyuqian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CC @Hixie to see if there are any comments on API changes.

CC @mikejurka @arbreng to see if there are any comments from Fuchsia or scenic.

@flar flar force-pushed the imagefiltered-widget-support branch from be6f5d4 to 802f3b5 Compare December 16, 2019 23:30
liyuqian
liyuqian approved these changes Dec 17, 2019
View reviewed changes
Copy link
Contributor

@liyuqian liyuqian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I'd also wait for @Hixie 's approval before landing as we're changing SceneBuilder's API. Reverting this commit could be a breaking change: we've added some APIs, and the revert is going to take them away.

Hixie
Hixie reviewed Dec 17, 2019
View reviewed changes
Hixie
Hixie reviewed Dec 17, 2019
View reviewed changes
Hixie
Hixie reviewed Dec 17, 2019
View reviewed changes
Hixie
Hixie reviewed Dec 17, 2019
View reviewed changes
Hixie
Hixie reviewed Dec 17, 2019
View reviewed changes
@Hixie
Copy link
Contributor

Hixie commented Dec 17, 2019

API LGTM.

@flar flar mentioned this pull request Dec 18, 2019
Merged
@liyuqian liyuqian mentioned this pull request Dec 19, 2019
Closed
@flar flar added the Work in progress (WIP) Not ready (yet) for review! label Dec 19, 2019
@flar
Copy link
Contributor Author

flar commented Dec 19, 2019

I added the WIP label while this PR waits for some pending pre-cursor fixes to land.

#14539

@flar flar force-pushed the imagefiltered-widget-support branch from 802f3b5 to 4150956 Compare December 19, 2019 23:28
@flar
Copy link
Contributor Author

flar commented Dec 20, 2019

Removing the WIP label as all the pieces seem to be in place...

@flar flar removed the Work in progress (WIP) Not ready (yet) for review! label Dec 20, 2019
@flar flar merged commit 929b1ed into flutter:master Dec 20, 2019
@flar flar mentioned this pull request Dec 20, 2019
Merged
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 20, 2019
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 20, 2019
@engine-flutter-autoroll
929b1ed Engine support for ImageFiltered widget (flutter/engine#14491)
236c062
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 20, 2019
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 20, 2019
@engine-flutter-autoroll
929b1ed Engine support for ImageFiltered widget (flutter/engine#14491)
2446cc2
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 20, 2019
@engine-flutter-autoroll
929b1ed Engine support for ImageFiltered widget (flutter/engine#14491)
9655448
This was referenced Dec 20, 2019
Closed
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 20, 2019
@engine-flutter-autoroll
929b1ed Engine support for ImageFiltered widget (flutter/engine#14491)
6fec969
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 20, 2019
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 20, 2019
@engine-flutter-autoroll
929b1ed Engine support for ImageFiltered widget (flutter/engine#14491)
5ba3607
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 20, 2019
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 20, 2019
@engine-flutter-autoroll
929b1ed Engine support for ImageFiltered widget (flutter/engine#14491)
9914d09
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Dec 20, 2019
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 20, 2019
@engine-flutter-autoroll
929b1ed Engine support for ImageFiltered widget (flutter/engine#14491)
081e777
@yjbanov yjbanov mentioned this pull request Dec 20, 2019
Merged
flar pushed a commit to flutter/flutter that referenced this pull request Dec 20, 2019
@engine-flutter-autoroll @flar
Roll engine 472197a..854d5f8 (20 commits) (#47503)
cb98f72 
* bb118c6 Roll src/third_party/dart 8d11c1dce64a..642f8d052fd7 (1 commits) (flutter/engine#14574)

* 09c434d Use ELF for Dart AOT snapshots on Fuchsia. (flutter/engine#13896)

* e1e7851 Roll fuchsia/sdk/core/linux-amd64 from VdBKA... to uFFWW... (flutter/engine#14575)

* f317f8f Roll src/third_party/skia c76ac8e325c7..77742c350371 (1 commits) (flutter/engine#14576)

* 2ba5633 instructions for running firefox/safari tests (flutter/engine#14562)

* 9cf1e46 Roll src/third_party/dart 642f8d052fd7..7113fc79a83c (3 commits) (flutter/engine#14578)

* f5b877a [web] Run engine tests on Safari locally by launching safari installed on MacOS (flutter/engine#14555)

* 68d9196 Fix DOM-based ParagraphRuler.hitTest() (flutter/engine#14504)

* bb65df8 Roll src/third_party/skia 77742c350371..a8352ccaae37 (8 commits) (flutter/engine#14579)

* ad1ab56 Roll src/third_party/dart 7113fc79a83c..e50d98cd5651 (8 commits) (flutter/engine#14580)

* 22413ef Update formatting in web_ui scene bulder to match flutter style and dartfmt. (flutter/engine#14539)

* 6e825e7 Roll fuchsia/sdk/core/mac-amd64 from Ykb4b... to f51Q_... (flutter/engine#14584)

* 1d3bb8c Fix message_loop_fuchsia and thus enable fml_tests and flow_tests for Fuchsia (flutter/engine#14583)

* 1f7bb9d Wire up OpacityLayer to Scenic (flutter/engine#14577)

* 11db035 Roll src/third_party/skia a8352ccaae37..87e9ddb675b6 (11 commits) (flutter/engine#14585)

* bd58af7 Roll src/third_party/dart e50d98cd5651..141fcfa61092 (3 commits) (flutter/engine#14586)

* 929b1ed Engine support for ImageFiltered widget (flutter/engine#14491)

* 40b84fc Fix lint warnings across web_ui, add missing browserEngine case in text field. (flutter/engine#14535)

* ea1d330 Roll fuchsia/sdk/core/linux-amd64 from uFFWW... to 25LzW... (flutter/engine#14587)

* 854d5f8 Roll src/third_party/skia 87e9ddb675b6..7e2dea568299 (1 commits) (flutter/engine#14589)
flar added a commit to flar/flutter that referenced this pull request Dec 21, 2019
@flar
Support for ImageFiltered widget to apply ImageFilter to children.
41ed180 
Framework counterpart to flutter/engine#14491
Fixes flutter#13489
@liyuqian liyuqian mentioned this pull request Jan 10, 2020
Closed
2 tasks
filmil pushed a commit to filmil/engine that referenced this pull request Mar 13, 2020
@flar @filmil
Engine support for ImageFiltered widget (flutter#14491)
f9a5bdc 
web_ui support coming in flutter/flutter#47163
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@arbreng arbreng Awaiting requested review from arbreng

@chinmaygarde chinmaygarde Awaiting requested review from chinmaygarde

3 more reviewers

@yjbanov yjbanov yjbanov approved these changes

@Hixie Hixie Hixie left review comments

@liyuqian liyuqian liyuqian approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@flar @Hixie @yjbanov @liyuqian @googlebot