Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Conversation

@a-siva
Copy link
Contributor

@a-siva a-siva commented Oct 16, 2019

dart-lang/sdk@41b65b27c2 [vm,aot] Simple unreachable code elimination before type-flow analysis
dart-lang/sdk@81679a2ab4 [analyzer] reduce the default number of times we repeat a benchmark
dart-lang/sdk@2e23776552 [dartdevc] Add new bot configuration for nnbd strong
dart-lang/sdk@cfe25c7e95 NNBD i13n: Sort navigation links
dart-lang/sdk@e642af52a5 Fix behavior of ML query construction
dart-lang/sdk@65bf2f0bcd [VM] Fix name demangling in AOT mode.
dart-lang/sdk@95bd6a2888 Fix --completion-model flag
dart-lang/sdk@dd5edfe0c2 Remove mentions of dart2js from isolate docs
dart-lang/sdk@f10d79618a [dart2js] Use generic function type parameters in RTI subtype check.
dart-lang/sdk@65813f5856 [analyzer/ffi] Extends dart:ffi specific analyzer checks
dart-lang/sdk@c5498891fc Don't suggest class member completions for ExtensionOverride targets.
dart-lang/sdk@69fa72dc17 Flow analysis: split interface and implementation, and add more doc comments.
dart-lang/sdk@6e042efd95 [vm/simarm] Fix VRECPS/VRSQRTSQS instruction implementation.
dart-lang/sdk@974d289181 [runtime/vm] ARM64: Support unaligned memory accesses for regex.
dart-lang/sdk@d24e9a0940 [vm/compiler] ARM64: Support unaligned memory accesses.
dart-lang/sdk@b368a6de1c [dartdevc] copying over sourcemap file from build_web_compilers
dart-lang/sdk@5300ce4a2d ADD_DIAGNOSTIC_PROPERTY_REFERENCE assist
dart-lang/sdk@3778839976 Fix version number that first supports ui-as-code; fixes #37898
dart-lang/sdk@0ee49dd7e5 (dart2js): Reduce worse-case complexity on dominator check in SsaSimplifyInterceptors
dart-lang/sdk@3e497dd00a diagnostic function field support
dart-lang/sdk@9e2ce9a773 [vm,bytecode] Avoid duplicated initializing StoreFieldTOS
dart-lang/sdk@438d3c154b [ dartfuzz ] Only emit new occasionally, replace rollDice(2) with coinFlip()
dart-lang/sdk@d82ca1a9c7 [vm/ffi] Remove Struct type argument
dart-lang/sdk@19e2f03421 NNBD i13n: Fix non-target reasons and add failing test for method return inheritance
dart-lang/sdk@0cada76a06 [SDK] Removes dart2aot.
dart-lang/sdk@f9648cb477 Fix doc comment for Element.animate
dart-lang/sdk@abecefd1ac Forward compatible portion of CL that does not set types for identifiers that are not expressions.
dart-lang/sdk@37a0c1ed93 Create FunctionTypeImpl.synthetic() in DDC.

dart-lang/sdk@41b65b27c2 [vm,aot] Simple unreachable code elimination before type-flow analysis
dart-lang/sdk@81679a2ab4 [analyzer] reduce the default number of times we repeat a benchmark
dart-lang/sdk@2e23776552 [dartdevc] Add new bot configuration for nnbd strong
dart-lang/sdk@cfe25c7e95 NNBD i13n: Sort navigation links
dart-lang/sdk@e642af52a5 Fix behavior of ML query construction
dart-lang/sdk@65bf2f0bcd [VM] Fix name demangling in AOT mode.
dart-lang/sdk@95bd6a2888 Fix --completion-model flag
dart-lang/sdk@dd5edfe0c2 Remove mentions of dart2js from isolate docs
dart-lang/sdk@f10d79618a [dart2js] Use generic function type parameters in RTI subtype check.
dart-lang/sdk@65813f5856 [analyzer/ffi] Extends dart:ffi specific analyzer checks
dart-lang/sdk@c5498891fc Don't suggest class member completions for ExtensionOverride targets.
dart-lang/sdk@69fa72dc17 Flow analysis: split interface and implementation, and add more doc comments.
dart-lang/sdk@6e042efd95 [vm/simarm] Fix VRECPS/VRSQRTSQS instruction implementation.
dart-lang/sdk@974d289181 [runtime/vm] ARM64: Support unaligned memory accesses for regex.
dart-lang/sdk@d24e9a0940 [vm/compiler] ARM64: Support unaligned memory accesses.
dart-lang/sdk@b368a6de1c [dartdevc] copying over sourcemap file from build_web_compilers
dart-lang/sdk@5300ce4a2d ADD_DIAGNOSTIC_PROPERTY_REFERENCE assist
dart-lang/sdk@3778839976 Fix version number that first supports ui-as-code; fixes flutter#37898
dart-lang/sdk@0ee49dd7e5 (dart2js): Reduce worse-case complexity on dominator check in SsaSimplifyInterceptors
dart-lang/sdk@3e497dd00a diagnostic function field support
dart-lang/sdk@9e2ce9a773 [vm,bytecode] Avoid duplicated initializing StoreFieldTOS
dart-lang/sdk@438d3c154b [ dartfuzz ] Only emit `new` occasionally, replace rollDice(2) with coinFlip()
dart-lang/sdk@d82ca1a9c7 [vm/ffi] Remove Struct type argument
dart-lang/sdk@19e2f03421 NNBD i13n: Fix non-target reasons and add failing test for method return inheritance
dart-lang/sdk@0cada76a06 [SDK] Removes dart2aot.
dart-lang/sdk@f9648cb477 Fix doc comment for Element.animate
dart-lang/sdk@abecefd1ac Forward compatible portion of CL that does not set types for identifiers that are not expressions.
dart-lang/sdk@37a0c1ed93 Create FunctionTypeImpl.synthetic() in DDC.
@a-siva a-siva requested review from aam and bkonyi October 16, 2019 01:45
@a-siva a-siva changed the title Roll src/third_party/dart 4131d3d7c4...41b65b27c2 (28 commits) Manual roll of src/third_party/dart 4131d3d7c4...41b65b27c2 (28 commits) Oct 16, 2019
@mkustermann
Copy link
Member

I assume there is nothing preventing this roll to get in, right? So I'll merge it now.

Though @sjindel-google mentions that the newest origin/master makes flutter gallery crash in profile mode. So we might have introduced an issue after the commits in this PR.

@mkustermann mkustermann merged commit 918fefc into flutter:master Oct 16, 2019
@mkustermann
Copy link
Member

mkustermann commented Oct 16, 2019

Though @sjindel-google mentions that the newest origin/master makes flutter gallery crash in profile mode

Update: I could not confirm this.

When I build head-head-head gallery in profile arm/arm64 as well as debug seems to work. So I'll prepare another roll in #13171

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 16, 2019
@a-siva a-siva deleted the dartroll branch October 16, 2019 16:26
engine-flutter-autoroll added a commit to flutter/flutter that referenced this pull request Oct 16, 2019
[email protected]:flutter/engine.git/compare/540fc977bb6b...5e6c005

git log 540fc97..5e6c005 --no-merges --oneline
2019-10-16 [email protected] Roll src/third_party/skia 083a75d6762c..59e72b71b5cf (1 commits) (flutter/engine#13169)
2019-10-16 [email protected] Roll src/third_party/dart 4131d3d7c4...41b65b27c2 (28 commits) (flutter/engine#13163)
2019-10-16 [email protected] Roll src/third_party/skia 7274850f96f2..083a75d6762c (1 commits) (flutter/engine#13168)
2019-10-16 [email protected] Roll fuchsia/sdk/core/linux-amd64 from 5I4Iw... to oTVah... (flutter/engine#13167)
2019-10-16 [email protected] Roll fuchsia/sdk/core/mac-amd64 from qpzUe... to KVDL4... (flutter/engine#13166)
2019-10-16 [email protected] Roll src/third_party/skia 634d15032d37..7274850f96f2 (3 commits) (flutter/engine#13165)
2019-10-16 [email protected] Move surface-based SceneBuilder implementation under surface/ (flutter/engine#13159)
2019-10-16 [email protected] Roll src/third_party/skia ba8752f37dab..634d15032d37 (2 commits) (flutter/engine#13164)
2019-10-16 [email protected] Revert "Issue 13238: on iOS, force an orientation change when the current orientation is not allowed" (flutter/engine#13160)
2019-10-15 [email protected] Roll buildroot to pull in static thread safety analysis options. (flutter/engine#13155)
2019-10-15 [email protected] Roll src/third_party/skia fb6a1abe4567..ba8752f37dab (8 commits) (flutter/engine#13156)
2019-10-15 [email protected] Make the Dart isolate constructor private. (flutter/engine#13153)
2019-10-15 [email protected] Revert "Upgrades the ICU version to 64.2 (#13123)" (flutter/engine#13146)
2019-10-15 [email protected] Issue 13238: on iOS, force an orientation change when the current orientation is not allowed (flutter/engine#12295)
2019-10-15 [email protected] Allow embedders to specify a render task runner description. (flutter/engine#13124)
2019-10-15 [email protected] Roll fuchsia/sdk/core/linux-amd64 from Jv4XM... to 5I4Iw... (flutter/engine#13150)
2019-10-15 [email protected] Roll fuchsia/sdk/core/mac-amd64 from i5xD1... to qpzUe... (flutter/engine#13149)
2019-10-15 [email protected] Roll src/third_party/dart fc933312f7..4131d3d7c4 (3 commits)
2019-10-15 [email protected] Document //flutter/runtime/dart_vm (flutter/engine#13144)
2019-10-15 [email protected] Revert "Enable/tweak web sdk source maps (#13141)" (flutter/engine#13148)
2019-10-15 [email protected] Merge the Fuchsia frontend_server build script into the new flutter_frontend_server target (flutter/engine#13145)
2019-10-15 [email protected] Add `flutter_tester` binary to the CIPD package (flutter/engine#13143)
2019-10-15 [email protected] Roll src/third_party/skia f22c57ddcc8c..fb6a1abe4567 (2 commits) (flutter/engine#13142)
2019-10-15 [email protected] Enable/tweak web sdk source maps (flutter/engine#13141)
2019-10-15 [email protected] Upgrades the ICU version to 64.2 (flutter/engine#13123)
2019-10-15 [email protected] [frontend_server] Include bytecode generation in the training run. (flutter/engine#13126)
2019-10-15 [email protected] Support empty strings and vectors in standard codec (flutter/engine#12974)
2019-10-15 [email protected] Roll src/third_party/dart 50f7ae9c5d..fc933312f7 (2 commits)
2019-10-15 [email protected] Roll src/third_party/skia 55f9cba6e2e7..f22c57ddcc8c (1 commits) (flutter/engine#13136)
2019-10-15 [email protected] Roll fuchsia/sdk/core/linux-amd64 from xRgq0... to Jv4XM... (flutter/engine#13135)
2019-10-15 [email protected] Roll fuchsia/sdk/core/mac-amd64 from Lk7iT... to i5xD1... (flutter/engine#13134)
2019-10-15 [email protected] Roll src/third_party/skia 858cf233ef71..55f9cba6e2e7 (3 commits) (flutter/engine#13133)
2019-10-15 [email protected] Roll src/third_party/dart 70a7ef3f58..50f7ae9c5d (18 commits)


If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
...
Inconnu08 pushed a commit to Inconnu08/flutter that referenced this pull request Nov 26, 2019
[email protected]:flutter/engine.git/compare/540fc977bb6b...5e6c005

git log 540fc97..5e6c005 --no-merges --oneline
2019-10-16 [email protected] Roll src/third_party/skia 083a75d6762c..59e72b71b5cf (1 commits) (flutter/engine#13169)
2019-10-16 [email protected] Roll src/third_party/dart 4131d3d7c4...41b65b27c2 (28 commits) (flutter/engine#13163)
2019-10-16 [email protected] Roll src/third_party/skia 7274850f96f2..083a75d6762c (1 commits) (flutter/engine#13168)
2019-10-16 [email protected] Roll fuchsia/sdk/core/linux-amd64 from 5I4Iw... to oTVah... (flutter/engine#13167)
2019-10-16 [email protected] Roll fuchsia/sdk/core/mac-amd64 from qpzUe... to KVDL4... (flutter/engine#13166)
2019-10-16 [email protected] Roll src/third_party/skia 634d15032d37..7274850f96f2 (3 commits) (flutter/engine#13165)
2019-10-16 [email protected] Move surface-based SceneBuilder implementation under surface/ (flutter/engine#13159)
2019-10-16 [email protected] Roll src/third_party/skia ba8752f37dab..634d15032d37 (2 commits) (flutter/engine#13164)
2019-10-16 [email protected] Revert "Issue 13238: on iOS, force an orientation change when the current orientation is not allowed" (flutter/engine#13160)
2019-10-15 [email protected] Roll buildroot to pull in static thread safety analysis options. (flutter/engine#13155)
2019-10-15 [email protected] Roll src/third_party/skia fb6a1abe4567..ba8752f37dab (8 commits) (flutter/engine#13156)
2019-10-15 [email protected] Make the Dart isolate constructor private. (flutter/engine#13153)
2019-10-15 [email protected] Revert "Upgrades the ICU version to 64.2 (flutter#13123)" (flutter/engine#13146)
2019-10-15 [email protected] Issue 13238: on iOS, force an orientation change when the current orientation is not allowed (flutter/engine#12295)
2019-10-15 [email protected] Allow embedders to specify a render task runner description. (flutter/engine#13124)
2019-10-15 [email protected] Roll fuchsia/sdk/core/linux-amd64 from Jv4XM... to 5I4Iw... (flutter/engine#13150)
2019-10-15 [email protected] Roll fuchsia/sdk/core/mac-amd64 from i5xD1... to qpzUe... (flutter/engine#13149)
2019-10-15 [email protected] Roll src/third_party/dart fc933312f7..4131d3d7c4 (3 commits)
2019-10-15 [email protected] Document //flutter/runtime/dart_vm (flutter/engine#13144)
2019-10-15 [email protected] Revert "Enable/tweak web sdk source maps (flutter#13141)" (flutter/engine#13148)
2019-10-15 [email protected] Merge the Fuchsia frontend_server build script into the new flutter_frontend_server target (flutter/engine#13145)
2019-10-15 [email protected] Add `flutter_tester` binary to the CIPD package (flutter/engine#13143)
2019-10-15 [email protected] Roll src/third_party/skia f22c57ddcc8c..fb6a1abe4567 (2 commits) (flutter/engine#13142)
2019-10-15 [email protected] Enable/tweak web sdk source maps (flutter/engine#13141)
2019-10-15 [email protected] Upgrades the ICU version to 64.2 (flutter/engine#13123)
2019-10-15 [email protected] [frontend_server] Include bytecode generation in the training run. (flutter/engine#13126)
2019-10-15 [email protected] Support empty strings and vectors in standard codec (flutter/engine#12974)
2019-10-15 [email protected] Roll src/third_party/dart 50f7ae9c5d..fc933312f7 (2 commits)
2019-10-15 [email protected] Roll src/third_party/skia 55f9cba6e2e7..f22c57ddcc8c (1 commits) (flutter/engine#13136)
2019-10-15 [email protected] Roll fuchsia/sdk/core/linux-amd64 from xRgq0... to Jv4XM... (flutter/engine#13135)
2019-10-15 [email protected] Roll fuchsia/sdk/core/mac-amd64 from Lk7iT... to i5xD1... (flutter/engine#13134)
2019-10-15 [email protected] Roll src/third_party/skia 858cf233ef71..55f9cba6e2e7 (3 commits) (flutter/engine#13133)
2019-10-15 [email protected] Roll src/third_party/dart 70a7ef3f58..50f7ae9c5d (18 commits)


If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC [email protected] on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
...
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants