Document //flutter/runtime/dart_vm #13144

chinmaygarde · 2019-10-15T19:04:09Z

jason-simmons · 2019-10-15T19:10:22Z

runtime/dart_vm.h

+///             time. The Dart VM may be created and destroyed on any thread.
+///             Typically, the first Flutter shell instance running in the
+///             process bootstraps the Dart VM in the process as it starts up.
+///             This cost is borne on he platform task runner of that first


typo: "the"

jason-simmons · 2019-10-15T19:12:10Z

runtime/dart_vm.h

+///             necessary to create a VM (even if they end up not being used).
+///
+///             In a running VM instance, the service isolate is launched by
+///             default is the VM is configured to do so. All root isolates must


jason-simmons · 2019-10-15T19:13:46Z

runtime/dart_vm.h

  std::shared_ptr<const DartVMData> GetVMData() const;

+  //----------------------------------------------------------------------------
+  /// @brief      The service protocol instance associated with this running VM


typo: remove "VM"

jason-simmons · 2019-10-15T19:14:21Z

runtime/dart_vm.h

  std::shared_ptr<IsolateNameServer> GetIsolateNameServer() const;

+  //----------------------------------------------------------------------------
+  /// @brief      The task runner whose tasks may may be executed concurrently


typo: remove second "may"

jason-simmons · 2019-10-15T19:14:52Z

runtime/dart_vm.h

+  ///             shell instance use this worker pool for their concurrent
+  ///             tasks. This also means that the concurrent worker pool may
+  ///             service tasks from multiple shell instances. The number of
+  ///             workers in a concurrent worker pool depending on the hardware


typo: change "depending" to "depends"

jason-simmons · 2019-10-15T19:15:15Z

runtime/dart_vm.h

+  ///
+  ///
+  /// @attention  Even though concurrent task queue is associated with a running
+  ///             Dart VM instance, the worker pool used to by the Flutter


typo: remove "to"

chinmaygarde

Addressed all comments.

chinmaygarde · 2019-10-15T20:47:28Z

runtime/dart_vm.h

+///             time. The Dart VM may be created and destroyed on any thread.
+///             Typically, the first Flutter shell instance running in the
+///             process bootstraps the Dart VM in the process as it starts up.
+///             This cost is borne on he platform task runner of that first


chinmaygarde · 2019-10-15T20:47:55Z

runtime/dart_vm.h

+///             necessary to create a VM (even if they end up not being used).
+///
+///             In a running VM instance, the service isolate is launched by
+///             default is the VM is configured to do so. All root isolates must


chinmaygarde · 2019-10-15T20:48:14Z

runtime/dart_vm.h

  std::shared_ptr<const DartVMData> GetVMData() const;

+  //----------------------------------------------------------------------------
+  /// @brief      The service protocol instance associated with this running VM


chinmaygarde · 2019-10-15T20:48:35Z

runtime/dart_vm.h

  std::shared_ptr<IsolateNameServer> GetIsolateNameServer() const;

+  //----------------------------------------------------------------------------
+  /// @brief      The task runner whose tasks may may be executed concurrently


chinmaygarde · 2019-10-15T20:48:50Z

runtime/dart_vm.h

+  ///             shell instance use this worker pool for their concurrent
+  ///             tasks. This also means that the concurrent worker pool may
+  ///             service tasks from multiple shell instances. The number of
+  ///             workers in a concurrent worker pool depending on the hardware


chinmaygarde · 2019-10-15T20:49:12Z

runtime/dart_vm.h

+  ///
+  ///
+  /// @attention  Even though concurrent task queue is associated with a running
+  ///             Dart VM instance, the worker pool used to by the Flutter


chinmaygarde · 2019-10-15T21:10:59Z

The LUCI error has been fixed on ToT.

[email protected]:flutter/engine.git/compare/540fc977bb6b...5e6c005 git log 540fc97..5e6c005 --no-merges --oneline 2019-10-16 [email protected] Roll src/third_party/skia 083a75d6762c..59e72b71b5cf (1 commits) (flutter/engine#13169) 2019-10-16 [email protected] Roll src/third_party/dart 4131d3d7c4...41b65b27c2 (28 commits) (flutter/engine#13163) 2019-10-16 [email protected] Roll src/third_party/skia 7274850f96f2..083a75d6762c (1 commits) (flutter/engine#13168) 2019-10-16 [email protected] Roll fuchsia/sdk/core/linux-amd64 from 5I4Iw... to oTVah... (flutter/engine#13167) 2019-10-16 [email protected] Roll fuchsia/sdk/core/mac-amd64 from qpzUe... to KVDL4... (flutter/engine#13166) 2019-10-16 [email protected] Roll src/third_party/skia 634d15032d37..7274850f96f2 (3 commits) (flutter/engine#13165) 2019-10-16 [email protected] Move surface-based SceneBuilder implementation under surface/ (flutter/engine#13159) 2019-10-16 [email protected] Roll src/third_party/skia ba8752f37dab..634d15032d37 (2 commits) (flutter/engine#13164) 2019-10-16 [email protected] Revert "Issue 13238: on iOS, force an orientation change when the current orientation is not allowed" (flutter/engine#13160) 2019-10-15 [email protected] Roll buildroot to pull in static thread safety analysis options. (flutter/engine#13155) 2019-10-15 [email protected] Roll src/third_party/skia fb6a1abe4567..ba8752f37dab (8 commits) (flutter/engine#13156) 2019-10-15 [email protected] Make the Dart isolate constructor private. (flutter/engine#13153) 2019-10-15 [email protected] Revert "Upgrades the ICU version to 64.2 (#13123)" (flutter/engine#13146) 2019-10-15 [email protected] Issue 13238: on iOS, force an orientation change when the current orientation is not allowed (flutter/engine#12295) 2019-10-15 [email protected] Allow embedders to specify a render task runner description. (flutter/engine#13124) 2019-10-15 [email protected] Roll fuchsia/sdk/core/linux-amd64 from Jv4XM... to 5I4Iw... (flutter/engine#13150) 2019-10-15 [email protected] Roll fuchsia/sdk/core/mac-amd64 from i5xD1... to qpzUe... (flutter/engine#13149) 2019-10-15 [email protected] Roll src/third_party/dart fc933312f7..4131d3d7c4 (3 commits) 2019-10-15 [email protected] Document //flutter/runtime/dart_vm (flutter/engine#13144) 2019-10-15 [email protected] Revert "Enable/tweak web sdk source maps (#13141)" (flutter/engine#13148) 2019-10-15 [email protected] Merge the Fuchsia frontend_server build script into the new flutter_frontend_server target (flutter/engine#13145) 2019-10-15 [email protected] Add `flutter_tester` binary to the CIPD package (flutter/engine#13143) 2019-10-15 [email protected] Roll src/third_party/skia f22c57ddcc8c..fb6a1abe4567 (2 commits) (flutter/engine#13142) 2019-10-15 [email protected] Enable/tweak web sdk source maps (flutter/engine#13141) 2019-10-15 [email protected] Upgrades the ICU version to 64.2 (flutter/engine#13123) 2019-10-15 [email protected] [frontend_server] Include bytecode generation in the training run. (flutter/engine#13126) 2019-10-15 [email protected] Support empty strings and vectors in standard codec (flutter/engine#12974) 2019-10-15 [email protected] Roll src/third_party/dart 50f7ae9c5d..fc933312f7 (2 commits) 2019-10-15 [email protected] Roll src/third_party/skia 55f9cba6e2e7..f22c57ddcc8c (1 commits) (flutter/engine#13136) 2019-10-15 [email protected] Roll fuchsia/sdk/core/linux-amd64 from xRgq0... to Jv4XM... (flutter/engine#13135) 2019-10-15 [email protected] Roll fuchsia/sdk/core/mac-amd64 from Lk7iT... to i5xD1... (flutter/engine#13134) 2019-10-15 [email protected] Roll src/third_party/skia 858cf233ef71..55f9cba6e2e7 (3 commits) (flutter/engine#13133) 2019-10-15 [email protected] Roll src/third_party/dart 70a7ef3f58..50f7ae9c5d (18 commits) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: ...

[email protected]:flutter/engine.git/compare/540fc977bb6b...5e6c005 git log 540fc97..5e6c005 --no-merges --oneline 2019-10-16 [email protected] Roll src/third_party/skia 083a75d6762c..59e72b71b5cf (1 commits) (flutter/engine#13169) 2019-10-16 [email protected] Roll src/third_party/dart 4131d3d7c4...41b65b27c2 (28 commits) (flutter/engine#13163) 2019-10-16 [email protected] Roll src/third_party/skia 7274850f96f2..083a75d6762c (1 commits) (flutter/engine#13168) 2019-10-16 [email protected] Roll fuchsia/sdk/core/linux-amd64 from 5I4Iw... to oTVah... (flutter/engine#13167) 2019-10-16 [email protected] Roll fuchsia/sdk/core/mac-amd64 from qpzUe... to KVDL4... (flutter/engine#13166) 2019-10-16 [email protected] Roll src/third_party/skia 634d15032d37..7274850f96f2 (3 commits) (flutter/engine#13165) 2019-10-16 [email protected] Move surface-based SceneBuilder implementation under surface/ (flutter/engine#13159) 2019-10-16 [email protected] Roll src/third_party/skia ba8752f37dab..634d15032d37 (2 commits) (flutter/engine#13164) 2019-10-16 [email protected] Revert "Issue 13238: on iOS, force an orientation change when the current orientation is not allowed" (flutter/engine#13160) 2019-10-15 [email protected] Roll buildroot to pull in static thread safety analysis options. (flutter/engine#13155) 2019-10-15 [email protected] Roll src/third_party/skia fb6a1abe4567..ba8752f37dab (8 commits) (flutter/engine#13156) 2019-10-15 [email protected] Make the Dart isolate constructor private. (flutter/engine#13153) 2019-10-15 [email protected] Revert "Upgrades the ICU version to 64.2 (flutter#13123)" (flutter/engine#13146) 2019-10-15 [email protected] Issue 13238: on iOS, force an orientation change when the current orientation is not allowed (flutter/engine#12295) 2019-10-15 [email protected] Allow embedders to specify a render task runner description. (flutter/engine#13124) 2019-10-15 [email protected] Roll fuchsia/sdk/core/linux-amd64 from Jv4XM... to 5I4Iw... (flutter/engine#13150) 2019-10-15 [email protected] Roll fuchsia/sdk/core/mac-amd64 from i5xD1... to qpzUe... (flutter/engine#13149) 2019-10-15 [email protected] Roll src/third_party/dart fc933312f7..4131d3d7c4 (3 commits) 2019-10-15 [email protected] Document //flutter/runtime/dart_vm (flutter/engine#13144) 2019-10-15 [email protected] Revert "Enable/tweak web sdk source maps (flutter#13141)" (flutter/engine#13148) 2019-10-15 [email protected] Merge the Fuchsia frontend_server build script into the new flutter_frontend_server target (flutter/engine#13145) 2019-10-15 [email protected] Add `flutter_tester` binary to the CIPD package (flutter/engine#13143) 2019-10-15 [email protected] Roll src/third_party/skia f22c57ddcc8c..fb6a1abe4567 (2 commits) (flutter/engine#13142) 2019-10-15 [email protected] Enable/tweak web sdk source maps (flutter/engine#13141) 2019-10-15 [email protected] Upgrades the ICU version to 64.2 (flutter/engine#13123) 2019-10-15 [email protected] [frontend_server] Include bytecode generation in the training run. (flutter/engine#13126) 2019-10-15 [email protected] Support empty strings and vectors in standard codec (flutter/engine#12974) 2019-10-15 [email protected] Roll src/third_party/dart 50f7ae9c5d..fc933312f7 (2 commits) 2019-10-15 [email protected] Roll src/third_party/skia 55f9cba6e2e7..f22c57ddcc8c (1 commits) (flutter/engine#13136) 2019-10-15 [email protected] Roll fuchsia/sdk/core/linux-amd64 from xRgq0... to Jv4XM... (flutter/engine#13135) 2019-10-15 [email protected] Roll fuchsia/sdk/core/mac-amd64 from Lk7iT... to i5xD1... (flutter/engine#13134) 2019-10-15 [email protected] Roll src/third_party/skia 858cf233ef71..55f9cba6e2e7 (3 commits) (flutter/engine#13133) 2019-10-15 [email protected] Roll src/third_party/dart 70a7ef3f58..50f7ae9c5d (18 commits) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected] on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: ...

Document //flutter/runtime/dart_vm

cd88106

chinmaygarde requested review from cbracken and jason-simmons October 15, 2019 19:04

googlebot added the cla: yes label Oct 15, 2019

jason-simmons reviewed Oct 15, 2019

View reviewed changes

Address PR comments.

65f77b1

chinmaygarde commented Oct 15, 2019

View reviewed changes

jason-simmons approved these changes Oct 15, 2019

View reviewed changes

chinmaygarde merged commit ecf325f into flutter:master Oct 15, 2019

chinmaygarde deleted the document_dartvm branch October 15, 2019 21:11

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 16, 2019

ecf325f Document //flutter/runtime/dart_vm (flutter/engine#13144)

52a0bca

engine-flutter-autoroll mentioned this pull request Oct 16, 2019

Roll engine 540fc977bb6b..5e6c005ef1f9 (33 commits) flutter/flutter#42853

Merged

Document //flutter/runtime/dart_vm #13144

Document //flutter/runtime/dart_vm #13144

Uh oh!

Conversation

chinmaygarde commented Oct 15, 2019

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

chinmaygarde left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

chinmaygarde commented Oct 15, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants