Skip to content

add hot reload benchmark card to dashboard #54

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yjbanov merged 1 commit into from
Sep 27, 2016
+75 −13
Merged

add hot reload benchmark card to dashboard #54

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 23 additions & 0 deletions app/web/fire.svg
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
43 changes: 31 additions & 12 deletions app/web/firebase.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,18 +8,7 @@ var whenFirebaseReady = new Promise(function(resolve, reject) {
console.log("User " + authData.uid + " is logged in with " +
authData.provider + " and has displayName '" +
authData.google.displayName + "' and email " + authData.google.email);
// Save the user's profile into the database so we can
// use them in Security and Firebase Rules.
// We don't trust this data, so don't rely on the email.
ref.child("users").child(authData.uid).set({
provider: authData.provider,
name: authData.google.displayName,
email: authData.google.email || 'undefined'
}).then(function(snapshot) {
resolve(ref);
}, function(error) {
console.error(error);
});
resolve(ref);
} else {
console.log("User is logged out");
}
Expand Down Expand Up @@ -197,6 +186,36 @@ var whenFirebaseReady = new Promise(function(resolve, reject) {
clone.querySelector('.metric-number').textContent =
Math.round(data.release_size_in_bytes / 1024).toLocaleString('en', { useGrouping: true });
document.querySelector('#container').appendChild(clone);
},

'__benchmark': function(measurementType, measurementName, data) {
var title = _getTitleForTemplate(measurementType, measurementName);
var clone;
if (title == 'hot_mode_dev_cycle') {
clone = _cloneTemplate('hot_reload_special_case');
var reloadSpan = clone.querySelector('#reload');
var restartSpan = clone.querySelector('#restart');
reloadSpan.textContent = _comma(data['hotReloadMillisecondsToFrame'].toString());
restartSpan.textContent = _comma(data['hotRestartMillisecondsToFrame'].toString());
} else {
clone = _cloneTemplate(measurementType);
clone.querySelector('.metric-name').textContent = title;
var cardInside = clone.querySelector('.card-inside');
for (var result of data['__golem__']) {
var name = result['benchmark_name'];

var resultContainer = document.createElement('div');
var resultName = document.createElement('span');
resultName.textContent = name.substring(name.indexOf('.') + 1);
resultContainer.appendChild(resultName);
var score = document.createElement('span');
score.textContent = `: ${ result['score'] }`;
resultContainer.appendChild(score);

cardInside.appendChild(resultContainer);
}
}
document.querySelector('#container').appendChild(clone);
}
};

Expand Down
22 changes: 21 additions & 1 deletion app/web/status.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,7 +147,7 @@
<div class="card timeline_summary from-firebase">
<div class="card-inside">
<div class="perf-test-summary-card">
<div class="metric-type">Scroll perf <span class="metric-name-wrapper">(<span class="metric-name"></span>)</span></div>
<div class="metric-type">Scroll perf <span class="metric-name-wrapper">(<span class="metric-name"></span>)</span></div>
<div class="metric-data"><span class="metric-number"></span><span class="metric-unit"> missed</span></div>
<!-- This box that contains aggregate numbers and declares success/failure -->
<div style="min-width: 150px">
Expand Down Expand Up @@ -201,6 +201,26 @@
</div>
</template>

<template id="__benchmark_tmpl">
<div class="card start_up from-firebase">
<div class="card-inside">
<div class="metric-type" style="margin-bottom: 10px">
Benchmark <span class="metric-name-wrapper">(<span class="metric-name"></span>)</span>
</div>
</div>
</div>
</template>

<template id="hot_reload_special_case_tmpl">
<div class="card start_up from-firebase">
<div class="card-inside">
<div class="metric-type" style="margin-bottom: 10px">Hot reload <img src="fire.svg" width="25"/></div>
<div class="metric-data"><span id="reload" class="metric-number"></span><span class="metric-unit">ms</span></div>
<div><span id="restart"></span>ms (restart)</div>
</div>
</div>
</template>

<script src="firebase.js"></script>
<script src="github.js"></script>
<script src="buildbot.js"></script>
Expand Down