Skip to content

Conversation

@yjbanov
Copy link
Contributor

@yjbanov yjbanov commented Sep 27, 2016

It looks like this:

screen shot 2016-09-26 at 4 58 42 pm

/cc @johnmccutchan @sethladd

@johnmccutchan
Copy link
Contributor

LGTM

@sethladd
Copy link

Can we make the number big top make it easy to see?
On Tue, Sep 27, 2016 at 06:46 John McCutchan [email protected]
wrote:

@johnmccutchan approved this pull request.


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#54 (review), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAAVZ7vReWqLfiZlEfBPlMQEwmuGm5jKks5quR4SgaJpZM4KHHyo
.

@yjbanov
Copy link
Contributor Author

yjbanov commented Sep 27, 2016

Can we make the number big top make it easy to see?

Open to ideas. The card will appear for every __benchmark build result (John's is the first of this type) with an unbounded number of metrics reported per benchmark. In this case, there are only two metrics reported. In another situation we may have many more numbers. If they are too big, they won't fit.

@sethladd
Copy link

Similar to how we have a big number for startup ms, let's make a big number for hot reload time to first frame.

@yjbanov
Copy link
Contributor Author

yjbanov commented Sep 27, 2016

How does this look?

screen shot 2016-09-27 at 12 25 49 pm

@eseidelGoogle
Copy link

Should be ms, no? :D

On Tue, Sep 27, 2016 at 12:26 PM, Yegor [email protected] wrote:

How does this look?

[image: screen shot 2016-09-27 at 12 25 49 pm]
https://cloud.githubusercontent.com/assets/211513/18888538/9fa42874-84ad-11e6-9e16-5dc5b4043ab3.png


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#54 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/ALTviw7ui5qd7oUdWFkoJFRN6Ll2adl7ks5quW3ygaJpZM4KHHyo
.

@yjbanov
Copy link
Contributor Author

yjbanov commented Sep 27, 2016

Should be ms, no? :D

I can convert to ms, if that's our preference.

@yjbanov
Copy link
Contributor Author

yjbanov commented Sep 27, 2016

What say ye?

screen shot 2016-09-27 at 12 32 26 pm

@eseidelGoogle
Copy link

lgtm

On Tue, Sep 27, 2016 at 12:33 PM, Yegor [email protected] wrote:

What say ye?

[image: screen shot 2016-09-27 at 12 32 26 pm]
https://cloud.githubusercontent.com/assets/211513/18888743/7f419a52-84ae-11e6-914f-cef2416aed20.png


You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#54 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/ALTviy1i_KfXeUWdqE7v3gwZwfoLz0vNks5quW9sgaJpZM4KHHyo
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants