Update third_party/zlib from Chromium #385
Conversation
Replaces third_party/zlib, which was originally forked from Chromium, with the latest copy from Chromium. BUILD.gn contains some changes to build in our buildroot without cascading changes: - Removes the `build_with_chromium` sections. - Removes optimization configuration adjustments that rely on buildroot-wide configuration options that are newer than our fork (removing default optimization settings, max_speed) - Removes an is_nacl condition, adds a previously-locally-added is_fuchsia check.
|
I'm not sure how I missed that the additional files I added before had a compile error against our older copy of zlib. Rather than continue to cherry-pick bits and pieces, it seemed better to just pull a full updated copy from Chromium. |
Pulls in flutter/buildroot#385 for build fix. (Will need license updates.)
chinmaygarde
left a comment
chinmaygarde
left a comment
There was a problem hiding this comment.
Rather than continue to cherry-pick bits and pieces, it seemed better to just pull a full updated copy from Chromium.
Sounds good. I didn't eyeball the whole patch. Happy to take a closer look at any part you point me to but otherwise lgtm.
|
Looks like this will require some non-trivial license updates (i.e., script, not just file path lists) so I'm making a separate roll PR for it (flutter/engine#20119) rather than rolling it as part of the ANGLE roll PR as originally planned. |
* Update third_party/zlib from Chromium Replaces third_party/zlib, which was originally forked from Chromium, with the latest copy from Chromium. BUILD.gn contains some changes to build in our buildroot without cascading changes: - Removes the `build_with_chromium` sections. - Removes optimization configuration adjustments that rely on buildroot-wide configuration options that are newer than our fork (removing default optimization settings, max_speed) - Removes an is_nacl condition, adds a previously-locally-added is_fuchsia check. - Adjusts path for Android cpu_features build dependency, which is different in Flutter
2 participants
Replaces third_party/zlib, which was originally forked from Chromium,
with the latest copy from Chromium.
BUILD.gn contains some changes to build in our buildroot without
cascading changes:
build_with_chromiumsections.buildroot-wide configuration options that are newer than our fork
(removing default optimization settings, max_speed)
is_fuchsia check.
This is needed to allow the Chromium zlib additions added in
#373 to build correctly.