This repository was archived by the owner on Apr 21, 2025. It is now read-only.
Update buildroot for ANGLE roll #373
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chinmaygarde
approved these changes
Jun 9, 2020
chinmaygarde
pushed a commit
to chinmaygarde/flutter_buildroot
that referenced
this pull request
May 4, 2021
This is necessary for flutter/engine#15868 Changes: - Adds third_party/zlib/google/ from Chromium, which is used by newer versions of ANGLE when building in Chromium-buildroot mode (which we do, since it's the closest match for us), and build rules for it. - Fixes the third_party/.gitignore to not ignore all subdirectories by default, only top-level directories (where we map in dependencies). - Adds `angle_has_build` to our GN rules, to match recent Chromium changes. Note: this requires some of the license script changes from the PR above in order to roll into the engine.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is necessary for flutter/engine#15868
Changes:
angle_has_buildto our GN rules, to match recent Chromium changes.Note: this requires some of the license script changes from the PR above in order to roll into the engine.