[connectivity_plus] Add bluetooth as connectivity result#362
Merged
swift-kim merged 2 commits intoApr 28, 2022
Conversation
github-actions
Bot
added
needs-publishing
swift-kim
commented
Apr 16, 2022
| case CONNECTION_TYPE_ETHERNET: | ||
| return ConnectionType::kEthernet; | ||
| case CONNECTION_TYPE_BT: | ||
| return ConnectionType::kBluetooth; |
Member
Author
There was a problem hiding this comment.
Should this function return ConnectionType::kBluetooth if the system reported network type is CONNECTION_TYPE_NET_PROXY? As far as I understand the proxy type means that the wearable device is using the bluetooth-connected phone's connection.
I just tested on my watch and found out that the device reports the current network type as CONNECTION_TYPE_ETHERNET when it's connected to a phone via bluetooth (even if the watch is connected to Wi-Fi simultaneously). I don't really understand why the Connection API works in this way.
Member
There was a problem hiding this comment.
Relax! 😄
Perhaps it is a gimmick that was entered because of a some scenario in the past.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support for
ConnectivityResult.bluetooth.Also reverts part of #352. The
EventChannelinstance must be preserved in memory during the plugin lifetime. See #134.