[connectivity_plus] Refactor the C++ code#352
Merged
swift-kim merged 1 commit intoApr 15, 2022
Conversation
bbrto21
reviewed
Apr 14, 2022
983b2a3 to
42244d9
Compare
bbrto21
approved these changes
Apr 14, 2022
This was referenced Apr 18, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of the code refactoring project. This change is an analogue of #351.
Connectionclass fromConnectivityPlusTizenPluginfor better separation of the platform channel communication and the device API usage. (I referred to the connectivity_plus_windows implementation.)ConnectionTypeto indicate the current connectivity type or an error status.RegisterObserver/ClearObserver→StartListen/StopListenStartListentakesConnectionTypeCallbackas an argument.GetType.EnsureConnectionHandle. The connection handle is now created and managed by theConnectionclass.ConnectivityStreamHandlerclass. Now the lifecycle ofEventSinkis solely managed by this class.SetupChannelsand combine withRegisterWithRegistrar.Additional note: The connectivity type "bluetooth" has been added to the platform interface and will be implemented in a later PR.