[firebase_auth] fix inconsistency between iOS and Android on FirebaseUserMetadata

packages/firebase_auth/CHANGELOG.md

@@ -1,3 +1,11 @@
+## 0.12.0
+
+* **Breaking change**: Replace `FirebaseUserMetadata.creationTimestamp` and
+  `FirebaseUserMetadata.lastSignInTimestamp` with `creationTime` and `lastSignInTime`.
+  Previously on iOS `creationTimestamp` and `lastSignInTimestamp` returned in
+  seconds and on Android in milliseconds. Now, both platforms provide values as a
+  `DateTime`.
+
 ## 0.11.1+12
 
 * Update google-services Android gradle plugin to 4.3.0 in documentation and examples.

packages/firebase_auth/example/test/firebase_auth.dart

@@ -3,9 +3,10 @@
 // BSD-style license that can be found in the LICENSE file.
 
 import 'dart:async';
+
+import 'package:firebase_auth/firebase_auth.dart';
 import 'package:flutter_driver/driver_extension.dart';
 import 'package:flutter_test/flutter_test.dart';
-import 'package:firebase_auth/firebase_auth.dart';
 
 void main() {
   final Completer<String> completer = Completer<String>();
@@ -19,6 +20,15 @@ void main() {
       final FirebaseUser user = await auth.signInAnonymously();
       expect(user.uid, isNotNull);
       expect(user.isAnonymous, isTrue);
+      expect(user.metadata.creationTime.isAfter(DateTime(2018, 1, 1)), isTrue);
+      expect(user.metadata.creationTime.isBefore(DateTime.now()), isTrue);
+      await auth.signOut();
+      final FirebaseUser user2 = await auth.signInAnonymously();
+      expect(user2.uid, isNot(equals(user.uid)));
+      expect(user2.metadata.creationTime.isBefore(user.metadata.creationTime),
+          isFalse);
+      expect(
+          user2.metadata.lastSignInTime, equals(user2.metadata.creationTime));
     });
 
     test('isSignInWithEmailLink', () async {

packages/firebase_auth/ios/Classes/FirebaseAuthPlugin.m

@@ -348,12 +348,12 @@ - (NSMutableDictionary *)dictionaryFromUser:(FIRUser *)user {
     [providerData addObject:toDictionary(userInfo)];
   }
 
-  long creationDate = [user.metadata.creationDate timeIntervalSince1970];
-  long lastSignInDate = [user.metadata.lastSignInDate timeIntervalSince1970];
+  long creationDate = [user.metadata.creationDate timeIntervalSince1970] * 1000;
+  long lastSignInDate = [user.metadata.lastSignInDate timeIntervalSince1970] * 1000;
 
   NSMutableDictionary *userData = [toDictionary(user) mutableCopy];
   userData[@"creationTimestamp"] = [NSNumber numberWithLong:creationDate];
-  userData[@"lastSignInTimestamp"] = [NSNumber numberWithInt:lastSignInDate];
+  userData[@"lastSignInTimestamp"] = [NSNumber numberWithLong:lastSignInDate];
   userData[@"isAnonymous"] = [NSNumber numberWithBool:user.isAnonymous];
   userData[@"isEmailVerified"] = [NSNumber numberWithBool:user.isEmailVerified];
   userData[@"providerData"] = providerData;

packages/firebase_auth/lib/src/user_metadata.dart

@@ -10,7 +10,13 @@ class FirebaseUserMetadata {
 
   final Map<String, dynamic> _data;
 
-  int get creationTimestamp => _data['creationTimestamp'];
+  /// The timestamp at which this account was created as dictated by the server clock.
+  DateTime get creationTime =>
+      DateTime.fromMillisecondsSinceEpoch(_data['creationTimestamp']);
 
-  int get lastSignInTimestamp => _data['lastSignInTimestamp'];
+  /// The last sign-in timestamp as dictated by the server clock.
+  ///
+  /// This is only accurate up to a granularity of 2 minutes for consecutive sign-in attempts.
+  DateTime get lastSignInTime =>
+      DateTime.fromMillisecondsSinceEpoch(_data['lastSignInTimestamp']);
 }

packages/firebase_auth/pubspec.yaml

@@ -4,7 +4,7 @@ description: Flutter plugin for Firebase Auth, enabling Android and iOS
   like Google, Facebook and Twitter.
 author: Flutter Team <flutter-dev@googlegroups.com>
 homepage: https://github.com/flutter/plugins/tree/master/packages/firebase_auth
-version: "0.11.1+12"
+version: "0.12.0"
 
 flutter:
   plugin:

packages/firebase_auth/test/firebase_auth_test.dart

@@ -25,6 +25,8 @@ const String kMockPhoneNumber = '5555555555';
 const String kMockVerificationId = '12345';
 const String kMockSmsCode = '123456';
 const String kMockLanguage = 'en';
+final DateTime kMockCreationTime = DateTime(2019, 1, 1);
+final DateTime kMockLastSignInTime = DateTime.now().subtract(const Duration(days: 1));
 
 void main() {
   group('$FirebaseAuth', () {
@@ -1229,6 +1231,10 @@ Map<String, dynamic> mockFirebaseUser(
           'email': email,
         },
       ],
+      'metadata': <String, dynamic>{
+        'creationTimestamp': kMockCreationTime.millisecondsSinceEpoch,
+        'lastSignInTimestamp': kMockLastSignInTime.millisecondsSinceEpoch,
+      },
     };
 
 /// Queue whose remove operation is asynchronous, awaiting a corresponding add.