Skip to content
This repository was archived by the owner on Feb 22, 2023. It is now read-only.

[firebase_auth] fix inconsistency between iOS and Android on FirebaseUserMetadata#1919

Merged
collinjackson merged 12 commits into
flutter-team-archive:masterfrom
long1eu:fix_ios_auth_inconsistancy
Jul 29, 2019
Merged

[firebase_auth] fix inconsistency between iOS and Android on FirebaseUserMetadata#1919
collinjackson merged 12 commits into
flutter-team-archive:masterfrom
long1eu:fix_ios_auth_inconsistancy

Conversation

@long1eu

@long1eu long1eu commented Jul 27, 2019

Copy link
Copy Markdown
Contributor

Description

On iOS creationTimestamp and lastSignInTimestamp were return in seconds and on Android in milliseconds. Now both platforms return those values in milliseconds (edit: as a DateTime).

Related Issues

flutter/flutter#27986

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • The title of the PR starts with the name of the plugin surrounded by square brackets, e.g. [shared_preferences]
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
  • No, this is not a breaking change.

@collinjackson

collinjackson commented Jul 27, 2019

Copy link
Copy Markdown
Contributor

This is a breaking change to the behavior and we're doing some other breaking changes to the library right now (see #1911) so I think it's a good time to update these method names and have them return a DateTime, which is more idiomatic for Dart. I've added these changes to your PR.

@collinjackson collinjackson merged commit e660990 into flutter-team-archive:master Jul 29, 2019
@long1eu long1eu deleted the fix_ios_auth_inconsistancy branch July 29, 2019 06:33
mithun-mondal pushed a commit to bKash-developer/archived_plugins that referenced this pull request Aug 6, 2019
…UserMetadata (flutter-team-archive#1919)

* [firebase_auth] fix inconsistency between iOS and Android on `FirebaseUserMetadata`

* Update to `creationTime` and `lastSignInTime`
julianscheel pushed a commit to jusst-engineering/plugins that referenced this pull request Mar 11, 2020
…UserMetadata (flutter-team-archive#1919)

* [firebase_auth] fix inconsistency between iOS and Android on `FirebaseUserMetadata`

* Update to `creationTime` and `lastSignInTime`
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants