Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Add and use a dart_test rule.#55630

Merged
matanlurey merged 1 commit into
flutter-team-archive:mainfrom
matanlurey:dart_test
Oct 3, 2024
Merged

Add and use a dart_test rule.#55630
matanlurey merged 1 commit into
flutter-team-archive:mainfrom
matanlurey:dart_test

Conversation

@matanlurey

Copy link
Copy Markdown
Contributor

Work towards flutter/flutter#147013.

I think I still need applicable metadata about the output, and then make sure et test understands everything:

% et test //flutter/tools/engine_tool/...
[2024-10-03 13:26:42.657137] ERROR: No test targets found

@matanlurey
matanlurey requested a review from cbracken October 3, 2024 20:26

@cbracken cbracken left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM stamp from a Japanese personal seal

@matanlurey
matanlurey merged commit b122e75 into flutter-team-archive:main Oct 3, 2024
@matanlurey
matanlurey deleted the dart_test branch October 3, 2024 21:41
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 3, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 3, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 4, 2024
auto-submit Bot pushed a commit to flutter/flutter that referenced this pull request Oct 4, 2024
flutter-team-archive/engine@20369c5...66d397d

2024-10-04 matanlurey@users.noreply.github.com Add missing license headers to `engine_tool`. (flutter-team-archive/engine#55636)
2024-10-03 robert.ancell@canonical.com Refactor FlKeyboardHandler (flutter-team-archive/engine#55601)
2024-10-03 matanlurey@users.noreply.github.com Add and use a `dart_test` rule. (flutter-team-archive/engine#55630)
2024-10-03 skia-flutter-autoroll@skia.org Roll Dart SDK from 4c767e0fae21 to 91d39199994c (1 revision) (flutter-team-archive/engine#55631)
2024-10-03 jonahwilliams@google.com [Impeller] ensure one AiksContext per app. (flutter-team-archive/engine#55629)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC matanl@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
nick9822 pushed a commit to nick9822/flutter that referenced this pull request Dec 18, 2024
Work towards flutter#147013.

I think I still need applicable metadata about the output, and then make
sure `et test` understands everything:

```sh
% et test //flutter/tools/engine_tool/...
[2024-10-03 13:26:42.657137] ERROR: No test targets found
```
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants