Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

[Impeller] ensure one AiksContext per app.#55629

Merged
auto-submit[bot] merged 10 commits into
flutter-team-archive:mainfrom
jonahwilliams:one_content_context
Oct 3, 2024
Merged

[Impeller] ensure one AiksContext per app.#55629
auto-submit[bot] merged 10 commits into
flutter-team-archive:mainfrom
jonahwilliams:one_content_context

Conversation

@jonahwilliams

Copy link
Copy Markdown
Contributor

Reland of #55393

@chinmaygarde chinmaygarde left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know what changed. But still lgtm 🙏🏽

@jonahwilliams

Copy link
Copy Markdown
Contributor Author

Merge conflict!

@jonahwilliams jonahwilliams added the autosubmit Merge PR when tree becomes green via auto submit App label Oct 3, 2024
@auto-submit
auto-submit Bot merged commit 6262d28 into flutter-team-archive:main Oct 3, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 3, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 3, 2024
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 4, 2024
auto-submit Bot pushed a commit to flutter/flutter that referenced this pull request Oct 4, 2024
flutter-team-archive/engine@20369c5...66d397d

2024-10-04 matanlurey@users.noreply.github.com Add missing license headers to `engine_tool`. (flutter-team-archive/engine#55636)
2024-10-03 robert.ancell@canonical.com Refactor FlKeyboardHandler (flutter-team-archive/engine#55601)
2024-10-03 matanlurey@users.noreply.github.com Add and use a `dart_test` rule. (flutter-team-archive/engine#55630)
2024-10-03 skia-flutter-autoroll@skia.org Roll Dart SDK from 4c767e0fae21 to 91d39199994c (1 revision) (flutter-team-archive/engine#55631)
2024-10-03 jonahwilliams@google.com [Impeller] ensure one AiksContext per app. (flutter-team-archive/engine#55629)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC matanl@google.com,zra@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

autosubmit Merge PR when tree becomes green via auto submit App platform-ios

Development

Successfully merging this pull request may close these issues.

2 participants