This repository was archived by the owner on Feb 25, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 6k
Update to very new gradle version #45124
Closed
reidbaker
wants to merge
5
commits into
flutter-team-archive:main
from
reidbaker:i133259-update-gradle-8
Closed
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
3fda77f
Update gradle to 7.5.1
reidbaker c8eb1ab
format nit
reidbaker f36cd11
Merge branch 'main' into i133259-update-gradle-7-5-1
reidbaker 42c1322
Update to gradle 8.3
reidbaker 8615f20
Merge branch 'main' into i133259-update-gradle-8
reidbaker File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,26 @@ | ||
| # Updating gradle version used in engine repo | ||
|
|
||
| The instructions in this README explain how to create a CIPD package that | ||
| contains the gradle build-time dependency of the Android embedding of the Engine. | ||
| The Android embedder is shipped to Flutter end-users, but gradle is not. | ||
|
|
||
| ## Requirements | ||
|
|
||
| 1. If you have a flutter/engine checkout, then you should already have | ||
| [Depot tools](http://commondatastorage.googleapis.com/chrome-infra-docs/flat/depot_tools/docs/html/depot_tools_tutorial.html#_setting_up) on your path. | ||
| 1. Ensure you have write access for cipd. go/flutter-luci-cipd | ||
| 1. Download the new version of gradle then verify the checksum, | ||
| and unzip into a local directory. | ||
|
|
||
| ## Update CIPD Steps | ||
| These steps use gradle version 7.5.1 as an example. | ||
|
|
||
| 1. Unzip gradle into a folder `unzip gradle-7.5.1-all.zip` | ||
| 1. Authenticate with cipd `cipd auth-login` | ||
| 1. Run `cipd create -in gradle-7.5.1 -install-mode copy -tag version:7.5.1 -name flutter/gradle` | ||
| 1. Update `engine/src/flutter/DEPS` gradle entry to contain the tag from the command above. | ||
| 1. Run `gclient sync` to verify that dependency can be fetched. | ||
|
|
||
| ## Useful links | ||
| * CIPD gradle https://chrome-infra-packages.appspot.com/p/flutter/gradle/+/ | ||
| * Gradle Releases https://gradle.org/releases/ | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
very minor nit: capitalize CIPD and Gradle for consistency, where not being used as part of a command