Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Update to very new gradle version #45124

Closed
reidbaker wants to merge 5 commits into
flutter-team-archive:mainfrom
reidbaker:i133259-update-gradle-8
Closed

Update to very new gradle version #45124
reidbaker wants to merge 5 commits into
flutter-team-archive:mainfrom
reidbaker:i133259-update-gradle-8

Conversation

@reidbaker

@reidbaker reidbaker commented Aug 25, 2023

Copy link
Copy Markdown
Contributor

Related to flutter/flutter#133259
This is a test to see if we can run on the latest gradle available.

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide] and the [C++, Objective-C, Java style guides].
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See [testing the engine] for instructions on writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the [CLA].
  • All existing and new tests are passing.

Comment thread tools/gradle/README.md
@@ -0,0 +1,26 @@
# Updating gradle version used in engine repo

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very minor nit: capitalize CIPD and Gradle for consistency, where not being used as part of a command

@reidbaker

Copy link
Copy Markdown
Contributor Author

This is not ready for review. I only have it up so that I can see what builds in ci.

@reidbaker

Copy link
Copy Markdown
Contributor Author

https://ci.chromium.org/ui/p/flutter/builders/try/Linux%20Engine%20Drone/1365541/overview

FAILURE: Build failed with an exception.

  • What went wrong:
    Could not determine the dependencies of task ':testDebugUnitTest'.

Could not create task ':processDebugManifest'.
Cannot use @TaskAction annotation on method IncrementalTask.taskAction$gradle_core() because interface org.gradle.api.tasks.incremental.IncrementalTaskInputs is not a valid parameter to an action method.

abandoning for more urgent work.

@reidbaker reidbaker closed this Sep 15, 2023
@reidbaker reidbaker deleted the i133259-update-gradle-8 branch September 15, 2023 17:13
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants