This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Revert "[lint + clang tidy] add lint check for python file changes"#39930
Merged
Conversation
This reverts commit d5316b6.
godofredoc
approved these changes
Feb 27, 2023
XilaiZhang
approved these changes
Feb 27, 2023
XilaiZhang
left a comment
XilaiZhang
left a comment
Contributor
There was a problem hiding this comment.
thanks for identifying and landing the fix so fast!
jmagman
added
the
autosubmit
Contributor
|
auto label is removed for flutter/engine, pr: 39930, due to - The status or check suite Linux Web Framework tests has failed. Please fix the issues identified (or deflake) before re-applying this label. |
auto-submit
Bot
removed
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 2, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 2, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 2, 2023
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 2, 2023
chinmaygarde
pushed a commit
to chinmaygarde/flutter_engine
that referenced
this pull request
Mar 3, 2023
…flutter-team-archive#39930) Revert "[lint + clang tidy] add lint check for python file changes"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #39736
The actual fix was related to glob behavior in flutter/cocoon#2506.
We don't need
*.pyto run in bothLinux Host clang-tidyandLinux Android clang-tidy, so remove the former.