Skip to content

Implement correct glob behavior in run_if. #2506

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
auto-submit merged 1 commit into from
Feb 27, 2023
Merged

Implement correct glob behavior in run_if. #2506

auto-submit merged 1 commit into from
Feb 27, 2023

Conversation

@godofredoc
Copy link
Contributor

@godofredoc godofredoc commented Feb 27, 2023

The recursive glob was matching a single character.

Bug: flutter/flutter#121160

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read the Flutter Style Guide recently, and have followed its advice.
  • I signed the CLA.
  • I listed at least one issue that this PR fixes in the description above.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@godofredoc
Implement correct glob behavior in run_if.
24023c2 
The recursive glob was matching a single character.

Bug: flutter/flutter#121160
@godofredoc godofredoc requested review from XilaiZhang, nehalvpatel, ricardoamador and yusuf-goog and removed request for ricardoamador February 27, 2023 22:01
XilaiZhang
XilaiZhang approved these changes Feb 27, 2023
View reviewed changes
Copy link
Contributor

@XilaiZhang XilaiZhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

images (1)

@godofredoc godofredoc added the autosubmit Merge PR when tree becomes green via auto submit App. label Feb 27, 2023
@auto-submit auto-submit bot merged commit 46d3b4c into flutter:main Feb 27, 2023
This was referenced Feb 27, 2023
Merged
Closed
@jmagman jmagman mentioned this pull request Mar 14, 2023
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nehalvpatel nehalvpatel Awaiting requested review from nehalvpatel

@yusuf-goog yusuf-goog Awaiting requested review from yusuf-goog

1 more reviewer

@XilaiZhang XilaiZhang XilaiZhang approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@godofredoc @XilaiZhang