fix multi cache dir #2639
Merged
fix multi cache dir #2639
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: zwwhdls <[email protected]>
|
/test fluid-e2e |
cheyang
reviewed
Feb 23, 2023
| // community doc: https://juicefs.com/docs/community/command_reference/#juicefs-mount | ||
| // enterprise doc: https://juicefs.com/docs/cloud/commands_reference#mount | ||
| // /mnt/disk1/bigboot or /mnt/disk1/bigboot:/mnt/disk2/bigboot | ||
| storagePath = tiredStoreLevel.Path |
There was a problem hiding this comment.
Please fix unit test. thanks.
Signed-off-by: zwwhdls <[email protected]>
|
/retest |
Codecov Report
@@ Coverage Diff @@
## master #2639 +/- ##
==========================================
+ Coverage 67.58% 67.63% +0.05%
==========================================
Files 369 369
Lines 21540 21579 +39
==========================================
+ Hits 14558 14596 +38
Misses 5274 5274
- Partials 1708 1709 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
/test fluid-e2e |
cheyang
approved these changes
Feb 24, 2023
|
/hold |
Signed-off-by: zwwhdls <[email protected]>
|
/test fluid-e2e |
Signed-off-by: zwwhdls <[email protected]>
Signed-off-by: zwwhdls <[email protected]>
cheyang
approved these changes
Feb 25, 2023
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cheyang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
cheyang
reviewed
Feb 25, 2023
| return | ||
| } | ||
| return | ||
| } |
There was a problem hiding this comment.
To prevent data loss from incorrect directory parameters, I suggest using regular expressions to validate before using "rm -rf" command. Is it possible for this case?
|
/test fluid-e2e |
|
/retest |
2 similar comments
|
/retest |
|
/retest |
Signed-off-by: zwwhdls <[email protected]>
|
/test fluid-e2e |
cheyang
reviewed
Feb 27, 2023
pkg/ddc/juicefs/operations/base.go
Outdated
| // cache dir check | ||
| match := ValidCacheDir(dir) | ||
| if !match { | ||
| err = fmt.Errorf("dir %s is not valid", dir) |
There was a problem hiding this comment.
How about using the following info？
err = fmt.Errorf("invalid cache directory %s, skip cleaning up", dir)
There was a problem hiding this comment.
@zwwhdls The code now returns an error but I think we should ignore the error if it's not a valid cache dir.
Signed-off-by: zwwhdls <[email protected]>
Signed-off-by: zwwhdls <[email protected]>
|
/unhold |
cheyang
pushed a commit
to cheyang/fluid
that referenced
this pull request
Mar 23, 2023
* fix multi cache dir Signed-off-by: zwwhdls <[email protected]> * fix unit test --------- Signed-off-by: zwwhdls <[email protected]>
cheyang
pushed a commit
to cheyang/fluid
that referenced
this pull request
Mar 23, 2023
* fix multi cache dir Signed-off-by: zwwhdls <[email protected]> * fix unit test --------- Signed-off-by: zwwhdls <[email protected]> Signed-off-by: cheyang <[email protected]>
cheyang
added a commit
that referenced
this pull request
Mar 27, 2023
* [juicefs] fix worker cache when set option (#2563) * fix worker cache when set option Signed-off-by: zwwhdls <[email protected]> * update changelog in chart Signed-off-by: zwwhdls <[email protected]> * fix unittest Signed-off-by: zwwhdls <[email protected]> --------- Signed-off-by: zwwhdls <[email protected]> Signed-off-by: cheyang <[email protected]> * fix multi cache dir (#2639) * fix multi cache dir Signed-off-by: zwwhdls <[email protected]> * fix unit test --------- Signed-off-by: zwwhdls <[email protected]> Signed-off-by: cheyang <[email protected]> * [Enhancement]CSI plugin checks mount point liveness before binding mount points (#2703) * Clean up broken mount point when NodeStageVolume Signed-off-by: dongyun.xzh <[email protected]> * Check mount point aliveness when NodePublishVolume Signed-off-by: dongyun.xzh <[email protected]> * Clean up broken mount point when NodeStageVolume Signed-off-by: dongyun.xzh <[email protected]> * Fix cleaning logic Signed-off-by: dongyun.xzh <[email protected]> --------- Signed-off-by: dongyun.xzh <[email protected]> Signed-off-by: cheyang <[email protected]> * Prettify error messages for exec.Commands in Fluid (#2718) * Prettify error log message when calling NodePublishVolume Signed-off-by: dongyun.xzh <[email protected]> * Prettify error logs when calling helm-related funcs Signed-off-by: dongyun.xzh <[email protected]> * Use instead `errors.As` Signed-off-by: dongyun.xzh <[email protected]> * Use instead `errors.As` Signed-off-by: dongyun.xzh <[email protected]> * Set higher log level for helm exec Signed-off-by: dongyun.xzh <[email protected]> --------- Signed-off-by: dongyun.xzh <[email protected]> Signed-off-by: cheyang <[email protected]> * update mount to check mountinfo, To #48327952 Signed-off-by: cheyang <[email protected]> * update mount to check mountinfo, To #48327952 Signed-off-by: cheyang <[email protected]> * Build docker images for v0.8.5, To #48327952 Signed-off-by: cheyang <[email protected]> --------- Signed-off-by: zwwhdls <[email protected]> Signed-off-by: cheyang <[email protected]> Signed-off-by: dongyun.xzh <[email protected]> Co-authored-by: Weiwei <[email protected]> Co-authored-by: TzZtzt <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR does
fix multi cache dir in juicefs runtime
Ⅱ. Does this pull request fix one issue?
fixes #2641
Ⅲ. List the added test cases (unit test/integration test) if any, please explain if no tests are needed.
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews