-
Notifications
You must be signed in to change notification settings - Fork 955
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[juicefs] fix worker cache when set option #2563
[juicefs] fix worker cache when set option #2563
Conversation
Signed-off-by: zwwhdls <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #2563 +/- ##
==========================================
+ Coverage 67.44% 67.54% +0.09%
==========================================
Files 368 368
Lines 21319 21412 +93
==========================================
+ Hits 14379 14462 +83
- Misses 5247 5256 +9
- Partials 1693 1694 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
/test fluid-e2e |
- mountPath: /root/script | ||
name: script | ||
{{- range $name, $mount := .Values.cacheDirs }} | ||
- name: cache-dir-{{ $name }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update changelog and chart version. thanks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
Signed-off-by: zwwhdls <[email protected]>
Signed-off-by: zwwhdls <[email protected]>
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cheyang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
* fix worker cache when set option Signed-off-by: zwwhdls <[email protected]> * update changelog in chart Signed-off-by: zwwhdls <[email protected]> * fix unittest Signed-off-by: zwwhdls <[email protected]> --------- Signed-off-by: zwwhdls <[email protected]>
* fix worker cache when set option Signed-off-by: zwwhdls <[email protected]> * update changelog in chart Signed-off-by: zwwhdls <[email protected]> * fix unittest Signed-off-by: zwwhdls <[email protected]> --------- Signed-off-by: zwwhdls <[email protected]>
* fix worker cache when set option Signed-off-by: zwwhdls <[email protected]> * update changelog in chart Signed-off-by: zwwhdls <[email protected]> * fix unittest Signed-off-by: zwwhdls <[email protected]> --------- Signed-off-by: zwwhdls <[email protected]>
* fix worker cache when set option Signed-off-by: zwwhdls <[email protected]> * update changelog in chart Signed-off-by: zwwhdls <[email protected]> * fix unittest Signed-off-by: zwwhdls <[email protected]> --------- Signed-off-by: zwwhdls <[email protected]> Signed-off-by: cheyang <[email protected]>
* fix worker cache when set option Signed-off-by: zwwhdls <[email protected]> * update changelog in chart Signed-off-by: zwwhdls <[email protected]> * fix unittest Signed-off-by: zwwhdls <[email protected]> --------- Signed-off-by: zwwhdls <[email protected]>
* fix worker cache when set option Signed-off-by: zwwhdls <[email protected]> * update changelog in chart Signed-off-by: zwwhdls <[email protected]> * fix unittest Signed-off-by: zwwhdls <[email protected]> --------- Signed-off-by: zwwhdls <[email protected]> Signed-off-by: cheyang <[email protected]>
* [juicefs] fix worker cache when set option (#2563) * fix worker cache when set option Signed-off-by: zwwhdls <[email protected]> * update changelog in chart Signed-off-by: zwwhdls <[email protected]> * fix unittest Signed-off-by: zwwhdls <[email protected]> --------- Signed-off-by: zwwhdls <[email protected]> Signed-off-by: cheyang <[email protected]> * fix multi cache dir (#2639) * fix multi cache dir Signed-off-by: zwwhdls <[email protected]> * fix unit test --------- Signed-off-by: zwwhdls <[email protected]> Signed-off-by: cheyang <[email protected]> * [Enhancement]CSI plugin checks mount point liveness before binding mount points (#2703) * Clean up broken mount point when NodeStageVolume Signed-off-by: dongyun.xzh <[email protected]> * Check mount point aliveness when NodePublishVolume Signed-off-by: dongyun.xzh <[email protected]> * Clean up broken mount point when NodeStageVolume Signed-off-by: dongyun.xzh <[email protected]> * Fix cleaning logic Signed-off-by: dongyun.xzh <[email protected]> --------- Signed-off-by: dongyun.xzh <[email protected]> Signed-off-by: cheyang <[email protected]> * Prettify error messages for exec.Commands in Fluid (#2718) * Prettify error log message when calling NodePublishVolume Signed-off-by: dongyun.xzh <[email protected]> * Prettify error logs when calling helm-related funcs Signed-off-by: dongyun.xzh <[email protected]> * Use instead `errors.As` Signed-off-by: dongyun.xzh <[email protected]> * Use instead `errors.As` Signed-off-by: dongyun.xzh <[email protected]> * Set higher log level for helm exec Signed-off-by: dongyun.xzh <[email protected]> --------- Signed-off-by: dongyun.xzh <[email protected]> Signed-off-by: cheyang <[email protected]> * update mount to check mountinfo, To #48327952 Signed-off-by: cheyang <[email protected]> * update mount to check mountinfo, To #48327952 Signed-off-by: cheyang <[email protected]> * Build docker images for v0.8.5, To #48327952 Signed-off-by: cheyang <[email protected]> --------- Signed-off-by: zwwhdls <[email protected]> Signed-off-by: cheyang <[email protected]> Signed-off-by: dongyun.xzh <[email protected]> Co-authored-by: Weiwei <[email protected]> Co-authored-by: TzZtzt <[email protected]>
Signed-off-by: zwwhdls [email protected]
Ⅰ. Describe what this PR does
When set
cache-dir
in worker options, juicefs worker will use different caches with fuse pod, and mount cache-dir in hostPath.Ⅱ. Does this pull request fix one issue?
fixes #2564
Ⅲ. List the added test cases (unit test/integration test) if any, please explain if no tests are needed.
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews