Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop unused @_plugin_id_configured from all own-able plugins #4320

Merged
merged 1 commit into from
Dec 19, 2023
Merged

Drop unused @_plugin_id_configured from all own-able plugins #4320

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion lib/fluent/plugin/owned_by_mixin.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@ def owner=(plugin)
@_owner = plugin

@_plugin_id = plugin.plugin_id
@_plugin_id_configured = plugin.plugin_id_configured?

@log = plugin.log
end
Expand Down
1 change: 0 additions & 1 deletion test/plugin/test_owned_by.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,6 @@ class OwnedByMixinTest < Test::Unit::TestCase

assert_equal parent.object_id, child.owner.object_id

assert child.instance_eval{ @_plugin_id_configured }
assert_equal 'my_parent_id', child.instance_eval{ @_plugin_id }

assert_equal Fluent::Log::LEVEL_TRACE, child.log.level
Expand Down
1 change: 0 additions & 1 deletion test/plugin/test_storage.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,6 @@ class StorageTest < Test::Unit::TestCase

assert_equal 'mytest', s.owner.system_config.process_name
assert_equal '1', s.instance_eval{ @_plugin_id }
assert_equal true, s.instance_eval{ @_plugin_id_configured }
end

test 'does NOT have features for high-performance/high-consistent storages' do
Expand Down
Loading