Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop unused @_plugin_id_configured from all own-able plugins #4320

Merged
merged 1 commit into from
Dec 19, 2023
Merged

Drop unused @_plugin_id_configured from all own-able plugins #4320

merged 1 commit into from
Dec 19, 2023

Conversation

isimluk
Copy link
Contributor

@isimluk isimluk commented Oct 10, 2023

This variable is unused since b32781d.

@isimluk isimluk force-pushed the minor-perf branch 2 times, most recently from 4fb1484 to 557daf7 Compare October 16, 2023 09:45
@daipom daipom added the enhancement Feature request or improve operations label Oct 17, 2023
@daipom
Copy link
Contributor

daipom commented Oct 17, 2023

Sorry, it may be a week or two before I can review this.
If other maintainers can't make time to review this, please wait a moment.

@ashie
Copy link
Member

ashie commented Oct 17, 2023 •
edited
Loading

@_plugin_id_configured is introduced at f601453 (v0.14.0.rc1) and removed at b32781d (v0.14.11).
It seems be able to remove safely since it's used only early stage of v0.14 series and @_ prefix (should be used only internally) is used.

@ashie ashie self-requested a review October 17, 2023 03:58
@isimluk
Drop unused @_plugin_id_configured from all own-able plugins
086b569 
This variable is unused since b32781d.

Signed-off-by: Šimon Lukašík <[email protected]>
@daipom daipom added this to the v1.17.0 milestone Oct 30, 2023
daipom
daipom approved these changes Dec 19, 2023
View reviewed changes
Copy link
Contributor

@daipom daipom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.
Sorry for the delay in merging this.
Now, I merge this to the master branch for v1.17.0.

Note: It seems that we don't need @_plugin_id either.

@daipom daipom merged commit d086b29 into fluent:master Dec 19, 2023
12 of 16 checks passed
@isimluk isimluk deleted the minor-perf branch December 20, 2023 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daipom daipom daipom approved these changes

@ashie ashie ashie approved these changes

Assignees
No one assigned
Labels
enhancement Feature request or improve operations
Projects
None yet
Milestone
v1.17.0
Development

Successfully merging this pull request may close these issues.
3 participants
@isimluk @daipom @ashie