Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suppress warning using different secondary for out_secondary_file #4087

Merged

Conversation

daipom
Copy link
Contributor

@daipom daipom commented Mar 9, 2023

Which issue(s) this PR fixes:
None.

What this PR does / why we need it:
Fluentd outputs the following warning message even when we use out_secondary_file for the secondary.

2023-03-09 14:50:10 +0900 [warn]: #0 Use different plugin for secondary. Check the plugin works with primary like secondary_file primary="Fluent::Plugin::FileOutput" secondary="Fluent::Plugin::SecondaryFileOutput"

Example config:

<source>
  @type sample
  tag test.hoge
  sample {"message": "hoge"}
</source>

<match test.**>
  @type file
  path /test/fluentd/log/${tag}/fluentd.log
  <format>
    @type single_value
  </format>
  <buffer tag>
    @type file
    path /test/fluentd/buffer
    flush_mode interval
    flush_interval 10s
  </buffer>
  <secondary>
    @type secondary_file
    directory /test/fluentd/error/
  </secondary>
</match>

This warning is meaningless when we use out_secondary_file for the secondary.

This PR suppresses it.

Docs Changes:
Not needed.

Release Note:
Same as the title.

The warning is meaningless when we use out_secondary_file for
secondary.

Signed-off-by: Daijiro Fukuda <[email protected]>
@ashie ashie merged commit fb64173 into fluent:master Mar 9, 2023
@ashie
Copy link
Member

ashie commented Mar 9, 2023

Thanks!

@daipom daipom deleted the suppress-secondary-warning-with-secondary_file branch March 9, 2023 06:25
@daipom
Copy link
Contributor Author

daipom commented Mar 9, 2023

Thanks for your review!

@ashie ashie added this to the v1.16.0 milestone Mar 15, 2023
daipom added a commit to daipom/fluentd that referenced this pull request Apr 3, 2023
Fix bug of 3a796cd (fluent#4087)

Signed-off-by: Daijiro Fukuda <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants