-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update fluentd to v1.16.0 #436
Conversation
3616de5
to
505196a
Compare
Install test failed on Windows:
fluent-package-builder/td-agent/msi/install-test.ps1 Lines 30 to 36 in 6655bc2
|
Hmm, cannot reproduce on my local environment... |
On my local Windows, the supervisor initialization looks like failing, and the supervisor and worker processes are not launched. This seems to be caused by the following fix. With the default config, the following warning log about the secondary occurs.
This process looks like the cause. When I checked the error as follows, begin
if (@secondary.class != SecondaryFileOutput) &&
(self.class != @secondary.class) &&
(@custom_format || @secondary.implement?(:custom_format))
log.warn "Use different plugin for secondary. Check the plugin works with primary like secondary_file", primary: self.class.to_s, secondary: @secondary.class.to_s
end
rescue => e
$log.error "Error: ", e
end I found this raises the following error.
|
I don't see why this phenomenon does not occur when running Fluentd normally... I can confirm this phenomenon occurs on macOS as well. |
This phenomenon is not specific to this package. I have made a PR to fix this. |
It's my mistake. I built the package with v1.15.3. |
Signed-off-by: Takuro Ashie <[email protected]>
The issue has been resolved by this. |
No description provided.