Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable sigdump after stop #4043

Merged
merged 1 commit into from
Feb 8, 2023

Conversation

abetomo
Copy link
Contributor

@abetomo abetomo commented Feb 7, 2023

Which issue(s) this PR fixes:
Fixes #3932

What this PR does / why we need it:
Don't generate sigdump files after stopping.
#4034 (comment)

Docs Changes:

None

Release Note:

Change to not generate a sigdump file after receiving a SIGTERM signal on non-Windows

Copy link
Contributor

@kou kou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Copy link
Member

@ashie ashie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ashie ashie requested a review from daipom February 7, 2023 23:58
Copy link
Contributor

@daipom daipom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the fix!

I have checked that Fluentd as a Windows Service can dump correctly by $ fluent-ctl dump.

What about Docs Changes and Release Note?

Docs Changes is the fix of https://github.com/fluent/fluentd-docs-gitbook corresponding to this fix.
I think we don't need it this time.

Release Note is used for https://github.com/fluent/fluentd/blob/master/CHANGELOG.md.
This is often the same as the title of the PR, but I think it is worth considering a little more this time.

@ashie ashie merged commit a5bf404 into fluent:master Feb 8, 2023
@ashie
Copy link
Member

ashie commented Feb 8, 2023

Merged. Thanks!

Docs Changes is the fix of https://github.com/fluent/fluentd-docs-gitbook corresponding to this fix.
I think we don't need it this time.

I also think it's not needed for this.

@abetomo abetomo deleted the feature/disable_sigdump_after_stop branch February 8, 2023 11:00
@abetomo
Copy link
Contributor Author

abetomo commented Feb 8, 2023

Release Note:

How about "Change to not generate a sigdump file after receiving a SIGTERM signal on non-Windows"?

@ashie ashie added this to the v1.16.0 milestone Feb 9, 2023
@daipom
Copy link
Contributor

daipom commented Feb 9, 2023

Release Note:

How about "Change to not generate a sigdump file after receiving a SIGTERM signal on non-Windows"?

Great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide option to ignore SIGCONT
4 participants