Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide option to ignore SIGCONT #3932

Closed
jregovic opened this issue Oct 27, 2022 · 5 comments · Fixed by #4043
Closed

Provide option to ignore SIGCONT #3932

jregovic opened this issue Oct 27, 2022 · 5 comments · Fixed by #4043
Assignees
Labels
bug Something isn't working

Comments

@jregovic
Copy link

Is your feature request related to a problem? Please describe.

When running under systemd, fluentd will produce a sigdump file even when a normal exit occurs.

Systemd sends a SIGCONT tot he process after the SIGTERM, which causes the sigdump file to be generated, putting unnecessary files in /tmp

Describe the solution you'd like

An option in the fluentd config file to disable producing sigdump files

Describe alternatives you've considered

We have adjusted settings for our systemd unit file, but systemd always sends the sigcont.

Additional context

No response

@fujimotos fujimotos added the feature request *Deprecated Label* Use enhancement label in general label Oct 27, 2022
@abetomo
Copy link
Contributor

abetomo commented Jan 31, 2023

I think disabling SIGCONT handler after SIGTERM will solve the problem.
(Suggested changes: #4034)

  1. Add option to disable sigdump
  2. Disable SIGCONT handler after SIGTERM
  3. Both 1 and 2

Which is better: 1, 2, or 3?

@ashie
Copy link
Member

ashie commented Feb 1, 2023

Thanks for the fix!
I think 2 is enough for addressing the issue.

We'll consider adding 1 if someone really requires it, but I think it's not needed for now.

@daipom daipom self-assigned this Feb 1, 2023
@daipom
Copy link
Contributor

daipom commented Feb 1, 2023

Thanks for the fix!
I will see it soon!

@daipom
Copy link
Contributor

daipom commented Feb 2, 2023

Note

https://www.freedesktop.org/software/systemd/man/systemd.kill.html#KillSignal=

right after sending the signal specified in this setting, systemd will always send SIGCONT, to ensure that even suspended tasks can be terminated cleanly.

So, for example, in td-agent, SIGCONT is sent after SIGTERM when stopping.

https://github.com/fluent/fluent-package-builder/blob/v4.4.2/td-agent/templates/etc/systemd/td-agent.service.erb#L28

@daipom
Copy link
Contributor

daipom commented Feb 2, 2023

I too think 2 is preferable for now.

@ashie ashie added bug Something isn't working and removed feature request *Deprecated Label* Use enhancement label in general labels Feb 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants