reenable gitlab ci failures #2544
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Anselm Eberhardt <[email protected]>
aeber
force-pushed
the
reenable_gitlab_failures
branch
from
c4194d5 to
ab49b07
Compare
|
@repeatedly You were doing #2460 . what do you think of this? |
The problem is test failures are caused by gitlab environment. |
|
Yeah, we should remove |
|
This PR has been automatically marked as stale because it has been open 90 days with no activity. Remove stale label or comment or this PR will be closed in 30 days |
|
This PR was automatically closed because of stale in 30 days |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue(s) this PR fixes:
Fixes #2542
What this PR does / why we need it:
This lets the Gitlab CI Jobs fail if tests do not pass.
Failing tests in the existing test suite indicate problems and should not be ignored.