Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gitlab CI always passes #2542

Closed
aeber opened this issue Aug 5, 2019 · 0 comments · Fixed by #3969
Closed

Gitlab CI always passes #2542

aeber opened this issue Aug 5, 2019 · 0 comments · Fixed by #3969
Labels
work-in-progress

Comments

@aeber
Copy link
Contributor

aeber commented Aug 5, 2019

Describe the bug

Gitlab CI always passes due to allow_failure: true in .gitlab-ci.yml.
Introduced by #2443.

To Reproduce
See: https://gitlab.com/fluent/fluentd/pipelines

Expected behavior
CI fails if tests fail.
@aeber aeber added the bug Something isn't working label Aug 5, 2019
@aeber aeber mentioned this issue Aug 5, 2019
Closed
@ganmacs ganmacs removed the bug Something isn't working label Aug 20, 2019
@ashie ashie mentioned this issue Nov 22, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
work-in-progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

CI: Remove GitLab CI fluent/fluentd
reenable gitlab ci failures dg-i/fluentd
2 participants
@ganmacs @aeber