Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitLab CI/CD Revised and Improved #2443

Merged
merged 5 commits into from
Jun 4, 2019
Merged

Conversation

Digi59404
Copy link
Contributor

@Digi59404 Digi59404 commented Jun 4, 2019

Which issue(s) this PR fixes:
Fixes # None Created

What this PR does / why we need it:

  1. This PR fixes the issue with the badge for GitLab on the Readme.
  2. This PR removes repeat code from the gitlab-ci file and streamlines the builds.
  3. This PR adds in the multiple targets for Ruby.

Docs Changes:
No Documentation Changes.

Release Note:
Fixes, Revises, and Improves GitLab CI files and processes.

Important:
While this PR adds all functionality to build and test FluentD as well as fixes the badge. A test failure still exists as the test suite expects a folder to be writeable in the container. Despite setting this folder to writeable; The test still fails.

This should not fail the CI/CD Pipeline at this stage. But it will need to be address on the testing code side.

@repeatedly repeatedly merged commit b3abefc into fluent:master Jun 4, 2019
@repeatedly
Copy link
Member

Thanks!
The test sometimes fails with timing issue.
Fix unstable test is TODO.

@repeatedly
Copy link
Member

@Digi59404 Just one question. GitLab CI doesn't support a trigger for github PR, right?

@aeber aeber mentioned this pull request Aug 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants