in_http: Add support for subdomain in CORS domain #2337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Hiroki Takayasu <[email protected]>
repeatedly
reviewed
Mar 20, 2019
lib/fluent/plugin/in_http.rb
Outdated
| return true | ||
| end | ||
| filtered_cors_allow_origins = @cors_allow_origins.select {|origin| origin != ""} | ||
| return filtered_cors_allow_origins.find {|origin| (start_str,end_str) = origin.split("*",2); @origin.start_with?(start_str) and @origin.end_with?(end_str)} != nil |
There was a problem hiding this comment.
Could you separate this one liner block into multiple lines?
By default, fluentd code doesn't use ; to force one line.
There was a problem hiding this comment.
Thanks for your review.
The contents pointed out were fixed. Do I need to git rebase -i ?
Signed-off-by: Hiroki Takayasu <[email protected]>
hirokikana
force-pushed
the
in-http-cors-subdomain
branch
from
1345395 to
def7c91
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Hiroki Takayasu [email protected]
Which issue(s) this PR fixes:
#2336
What this PR does / why we need it:
Currently
cors_allow_originscould only use*or exact matching. I modified able to could use wildcard in domain setting(ex:http://*.example.com)Docs Changes:
No need
Release Note:
See PR title