Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

http_in plugin cors_allow_origins be able to specify wildcard subdomains #2336

Closed
hirokikana opened this issue Mar 19, 2019 · 2 comments
Closed

http_in plugin cors_allow_origins be able to specify wildcard subdomains #2336

hirokikana opened this issue Mar 19, 2019 · 2 comments
Labels
enhancement Feature request or improve operations

Comments

@hirokikana
Copy link
Contributor

cors_allow_origins is support * or the exact matching. HTTP request from many subdomain case is need to add many domain in cors_allow_origins setting.

I want to specify wildcard subdomain as a solution. But, according to Access-Control-Allow-Origin header specification unusable( https://www.w3.org/TR/cors/#access-control-allow-origin-response-header ).

May I add this feature? If allowed, I can create PullRequest.
@repeatedly
Copy link
Member

May I add this feature? If allowed, I can create PullRequest.

yes please :)

@repeatedly repeatedly added the enhancement Feature request or improve operations label Mar 19, 2019
@hirokikana hirokikana mentioned this issue Mar 19, 2019
Merged
@repeatedly
Copy link
Member

Patch is merged. Forgot to close.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Feature request or improve operations
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@repeatedly @hirokikana