Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

output: Work retry_forever and <secondary> together. fix #2257 #2276

Merged
merged 1 commit into from
Feb 1, 2019
Merged

output: Work retry_forever and <secondary> together. fix #2257 #2276

merged 1 commit into from
Feb 1, 2019

Conversation

repeatedly
Copy link
Member

Enable retry_forever with <secondary>.
Only unrecoverable errors are moved to secondary output.

Signed-off-by: Masahiro Nakagawa [email protected]

@repeatedly repeatedly added v1 enhancement Feature request or improve operations labels Jan 25, 2019
@repeatedly repeatedly requested a review from cosmo0920 January 25, 2019 11:40
@repeatedly repeatedly mentioned this pull request Jan 25, 2019
Closed
cosmo0920
cosmo0920 approved these changes Jan 25, 2019
View reviewed changes
Copy link
Contributor

@cosmo0920 cosmo0920 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable. 👍

@repeatedly repeatedly merged commit 407f674 into master Feb 1, 2019
@ganmacs ganmacs deleted the support-retry_forever-and-secondary branch July 11, 2019 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cosmo0920 cosmo0920 cosmo0920 approved these changes

Assignees
No one assigned
Labels
enhancement Feature request or improve operations v1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@repeatedly @cosmo0920