Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Buffer options retry_forever and secondary shouldn't be exclusive #2257

Closed
yann-soubeyrand opened this issue Jan 8, 2019 · 3 comments
Closed
Assignees
Labels
enhancement Feature request or improve operations

Comments

@yann-soubeyrand
Copy link

Hi,

In my opinion, buffer options retry_forever and secondary output shouldn't be exclusive. Indeed, I expect Fluentd to retry forever in case of recoverable errors, but to proceed with secondary in case of unrecoverable errors. In my understanding, the code already works like this and the only thing to do is to remove the configuration constraint (to confirm by someone more familiar with Fluentd's code).

@repeatedly
Copy link
Member

Looks good to me. I will check the code.

@repeatedly repeatedly self-assigned this Jan 25, 2019
@repeatedly repeatedly added the enhancement Feature request or improve operations label Jan 25, 2019
@repeatedly
Copy link
Member

Patch is here: #2276

@yann-soubeyrand
Copy link
Author

Thanks a lot!

repeatedly added a commit that referenced this issue Feb 1, 2019
output: Work retry_forever and <secondary> together. fix #2257
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Feature request or improve operations
Projects
None yet
Development

No branches or pull requests

2 participants