Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug to ignore some command line options #1398

Merged
merged 2 commits into from
Jan 4, 2017

Conversation

tagomoris
Copy link
Member

Currently, supervisor overwrites values from command line options by system config values (even if no parameters are configured in <system> sections).
This makes a bug to ignore some command line options, which can be configured via both of command line options and system config section (For example, --suppress-config-dump).

This change makes command line options prior than system config parameters.
It's just standard way in all daemon software.

@tagomoris tagomoris added bug Something isn't working v0.14 labels Jan 4, 2017
@tagomoris tagomoris requested a review from repeatedly January 4, 2017 08:10
@tagomoris
Copy link
Member Author

@repeatedly could you review this?

@repeatedly
Copy link
Member

LGTM

@tagomoris tagomoris merged commit a64f77d into master Jan 4, 2017
@tagomoris tagomoris deleted the fix-to-enable-command-line-options branch January 4, 2017 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working v0.14
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants