Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some command line options does not work #1385

Closed
tagomoris opened this issue Dec 22, 2016 · 1 comment
Closed

Some command line options does not work #1385

tagomoris opened this issue Dec 22, 2016 · 1 comment
Assignees
Labels
bug Something isn't working v0.12

Comments

@tagomoris
Copy link
Member

Some configuration parameters exist both in command line options and system config.
For example, --suppress-repeated-stacktrace, --suppress-config-dump (and now i'm adding --workers).

Engine and other codes (in worker process) refers system_config object to handle these configuration values.
But Supervisor doesn't merge its configuration values (in instance variables) into system config object. So Engine.system_config has values just from <system> section in configuration files.

This causes that some command line options doesn't work as expected.

$ bundle exec bin/fluentd -c example/suppress_config_dump.conf --suppress-config-dump
{:here=>"suppress_config_dump", :value=>true}
2016-12-22 19:49:15 +0900 [info]: reading config file path="example/suppress_config_dump.conf"
2016-12-22 19:49:15 +0900 [info]: starting fluentd-0.14.10 pid=20088
2016-12-22 19:49:15 +0900 [info]: spawn command to main:  cmdline=["/Users/tagomoris/.rbenv/versions/2.3.1/bin/ruby", "-Eascii-8bit:ascii-8bit", "-rbundler/setup", "bin/fluentd", "-c", "example/suppress_config_dump.conf", "--suppress-config-dump", "--under-supervisor"]
2016-12-22 19:49:15 +0900 [info]: reading config file path="example/suppress_config_dump.conf"
2016-12-22 19:49:15 +0900 [info]: starting fluentd-0.14.10 without supervision pid=20117
2016-12-22 19:49:15 +0900 [info]: gem 'fluentd' version '0.14.10'
2016-12-22 19:49:15 +0900 [info]: adding match pattern="data.*" type="stdout"
2016-12-22 19:49:15 +0900 [info]: using configuration file: <ROOT>
  <system>
  </system>
  <match data.*>
    @type stdout
  </match>
</ROOT>
2016-12-22 19:49:15 +0900 [info]: starting fluentd worker pid=20117 ppid=20088 worker=0
@tagomoris tagomoris added bug Something isn't working v0.12 v0.14 labels Dec 22, 2016
@tagomoris tagomoris self-assigned this Dec 22, 2016
@tagomoris tagomoris removed the v0.14 label Jan 4, 2017
@tagomoris
Copy link
Member Author

#1398 fixes this problem in v0.14.

@tagomoris tagomoris assigned repeatedly and unassigned tagomoris Jan 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working v0.12
Projects
None yet
Development

No branches or pull requests

2 participants