Event router for secondary output #1283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… to secondary output plugins. context_router is the default event router for filters/outputs in <label> sections.
|
@repeatedly could you review this change? |
repeatedly
reviewed
Oct 19, 2016
| @router | ||
| end | ||
|
|
||
| def router=(r) | ||
| # not recommended now... |
There was a problem hiding this comment.
How about logging warn message here?
There was a problem hiding this comment.
I thought about it at first, but didn't it finally. Because we can't remove #router= method between v0.x and v1.x for compatibility reason. So displaying warning doesn't help anything.
IMO we should show warning here at the same time with deprecating v0.12 plugin APIs (and remove this method at v2).
There was a problem hiding this comment.
I see. I understood the situation.
|
Others are good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change introduces
context_routerfor all plugin types to provide event_router to secondary output plugins.context_routeris the default event router for filters/outputs in<label>sections.This fixes #1271.