Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Current Output plugin base class has a probrem that it needs router method if secondary uses router. #1271

Closed
joker1007 opened this issue Oct 10, 2016 · 0 comments · Fixed by #1283
Assignees
Labels
bug Something isn't working v0.14

Comments

@joker1007
Copy link
Contributor

  • fluentd (v0.14.7)
  • All envs

Current Fluent::Plugin::Output has following statement in configure method.

          @secondary.router = router if @secondary.has_router?

In current version, If secondary output uses compat layer (compat layer always include :event_emitter) or secondary output uses :event_emitter helper, primary output always needs :event_emitter.
In short, If user wants to use secondary output, almost output plugin needs :event_emitter at present.

@joker1007 joker1007 changed the title Current Output plugin base class have a probrem that it needs router method if secondary uses router. Current Output plugin base class has a probrem that it needs router method if secondary uses router. Oct 10, 2016
@tagomoris tagomoris self-assigned this Oct 18, 2016
@tagomoris tagomoris added bug Something isn't working v0.14 labels Oct 18, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working v0.14
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants