Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite wrong description about path of file buffer plugin #386

Merged
merged 7 commits into from
Jul 8, 2022

Conversation

ashie
Copy link
Member

@ashie ashie commented Dec 27, 2021

Although it seems based on v0.12, it's not applicable for v0.14 or later.
We should rewrite it.

refs: fluent/fluentd#3552

Although it seems based on v0.12, it's not applicable for v0.14 or
later. We should rewrite it.

Signed-off-by: Takuro Ashie <[email protected]>
@ashie ashie changed the title Remove wrong description about path of file buffer plugin Rewrite wrong description about path of file buffer plugin Dec 27, 2021
daipom added 3 commits July 7, 2022 18:26
Signed-off-by: Daijiro Fukuda <[email protected]>
daipom and others added 3 commits July 7, 2022 18:51
Signed-off-by: Daijiro Fukuda <[email protected]>
…ukuda

Add fix to "Rewrite wrong description about path of file buffer plugin"
@ashie ashie marked this pull request as ready for review July 7, 2022 23:59
@ashie
Copy link
Member Author

ashie commented Jul 8, 2022

Actual rewriting has been done by @daipom at #415, it looks good to me.

@ashie ashie merged commit b79d3ad into 1.0 Jul 8, 2022
@ashie ashie deleted the rewrite-buffer-path-description branch July 8, 2022 00:07
@daipom
Copy link
Contributor

daipom commented Jul 8, 2022

Thanks for reviewing and merging!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants