Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove time and tag within S3 file #9

Closed
kzk opened this issue Dec 5, 2012 · 6 comments
Closed

Remove time and tag within S3 file #9

kzk opened this issue Dec 5, 2012 · 6 comments
Assignees

Comments

@kzk
Copy link
Member

kzk commented Dec 5, 2012

.@x0jellio requested me that they only want JSON per line at S3 file, doesn't want to have tag and time within a same line. This is pretty reasonable and got the same inquiry from multiple users.

So we could introduce the option, to remove time and tag from S3 file and dump only JSON (maybe json_only or record_only?)

https://github.com/fluent/fluent-plugin-s3/blob/master/lib/fluent/plugin/out_s3.rb#L43

@ghost ghost assigned kzk and repeatedly Dec 5, 2012
@kzk
Copy link
Member Author

kzk commented Dec 5, 2012

discussed with @frsyuki, and he prefers 'format_json' as an option name.

@ghost ghost assigned kzk Dec 6, 2012
@tagomoris
Copy link
Member

FYI: output_include_time and output_include_tag options available with:

  • fluent-plugin-webhdfs
  • fluent-plugin-file-alternative
  • or other fluent-mixin-plaintextformatter included

@kzk
Copy link
Member Author

kzk commented Dec 6, 2012

btw, @x0jellio sent a note to me that he's only interested in records. Meaning no need to include time and tag to the record.

@repeatedly
Copy link
Member

There are 3 situations. Configuration example below:

  • Keep default format

format_json: false

2012-12-06T03:14:50Z    s3.hoge {"json":"message"}
  • Remove time / tag from same line

format_json: true

{"json":"message"}
  • Remove time / tag from same line and add removed time / tag to the record via default mixins

format_json: true
include_tag_key: true
include_time_key: true

{"json":"message", "tag":"s3.hoge", "time":1354763690}

What do you think?

@repeatedly
Copy link
Member

All

I pushed first implementation to suppor-format-json branch.
Please check!

@repeatedly
Copy link
Member

I think this issue is already resolved.

If you have more opinions, please reopen this issue.

chillaxd pushed a commit to chillaxd/fluent-plugin-s3 that referenced this issue Dec 19, 2016
# This is the 1st commit message:

# This is a combination of 3 commits.
# This is the 1st commit message:
# This is a combination of 3 commits.
# This is the 1st commit message:
Out S3 change

so that user can use minimal policy at AWS, to work with fluentd
like S3:PutObject

# This is the commit message fluent#2:

Spacing handled in out-S3 plugin

# This is the commit message fluent#3:

Identation modified

# This is the commit message fluent#4:

Introduce check_bucket paramater
To skip the using of auto_create_bucket for bucket existence checking

# This is the commit message fluent#5:

Fixes:

Test cases added.
README has been modified with check_bucket's usage and sample AWS policy.

# This is the commit message fluent#6:

Fixes:

Issues for extra spoaces. Modified

# This is the commit message fluent#7:

Spacing issues

# This is the commit message fluent#8:

Update test_out_s3.rb

# This is the commit message fluent#9:

time slicer modified for utc also

# This is the commit message fluent#10:

removing test cases

# This is the commit message fluent#1:

renaming time_slicer variable

# This is the commit message fluent#2:

Test casees added

Test cases for out_s3 plugin has been added. This feature will work with hardened
S3 policy like with only PutObject permission. As it will not check bucket existence
not even object existence, as for each object creation it will name it with timestamp.
So anyhow it will be unique everytime.

Only thing it willl assume that bucket is created already.

# This is the commit message fluent#3:

Some variable renamed

# This is the commit message fluent#2:

Clean up dependencies

# This is the commit message fluent#3:

Update README for placeholders

# This is the commit message fluent#2:

v0.8.0.rc1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants