Add librdkafka based consumer #367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tamas Kornai <[email protected]>
Signed-off-by: Tamas Kornai <[email protected]>
Signed-off-by: Tamas Kornai <[email protected]>
tkornai
force-pushed
the
in-rdkafka-group-history
branch
from
8d6a9d0 to
b225673
Compare
This was referenced Sep 8, 2020
Closed
|
I have just commented on old PR. Check my review: #366 (review) |
Signed-off-by: Tamas Kornai <[email protected]>
Signed-off-by: Tamas Kornai <[email protected]>
|
Thanks @repeatedly and @robinp-tw for the comments, I tried to address all of them. |
repeatedly
reviewed
Sep 9, 2020
Signed-off-by: Tamas Kornai <[email protected]>
|
Hi @repeatedly, thanks for your help with this change set. Quick question regarding the next steps. Should I add a disclaimer somewhere about the new input plugin being in a "beta" state? Or is there anything else that I should do so the PR can be merged? |
If you want to put it, there are 2 approaches:
|
|
Decided to do both. Is there anything else I should take care of? |
Signed-off-by: Tamas Kornai <[email protected]>
tkornai
force-pushed
the
in-rdkafka-group-history
branch
from
7e65adc to
b65c75d
Compare
|
Merged. I will release new version soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hence solving for #350
Only tested locally, not ready for production use yet.
Checking the last commit in this PR shows diffs agains the in_kafka_group implementation which I used as a template.